search

noaignite / create-ignite-app

Boilerplate for React with Next.js and MUI
17 stars 2 forks source link

fix(eslint-storybook): resolve dependency cycle of entity 'Page' #91

Closed adamsoderstrom closed 1 year ago

adamsoderstrom commented 1 year ago

This resolves dependency cycle, by removing the export of 'Page' in '~/containers/index.js'.

"But shouldn't it be exported?" Well, yes, you may think so. But in almost every scenario, it will be imported without any other container.

maeertin commented 1 year ago

image

I wonder what might have gone wrong as this PR contains a lint error. Could it be that the git hooks did not run or that just this file was not linted upon commit? @adamsoderstrom

adamsoderstrom commented 1 year ago

Hm... yeah. That error became appeared for me as well. I didn't resolve it in this PR, hence it doesn't relate to the dependency cycle.

I get the linting error while running rm .eslintcache && yarn install && yarn lint on develop aswell.

@maeertin

maeertin commented 1 year ago

Gotcha, I'll close the PR and look at the eslint error separately then 👍