search

noctux / adora-belle

A simple helpdesk tailored for use in remote-only university exercises
GNU Affero General Public License v3.0
2 stars 7 forks source link

Play Sound on new Request (II) #3

Closed phikal closed 4 years ago

phikal commented 4 years ago

Same as in #2, just with the mentioned changes.

Once again, I could not test this because I don't know how to build the server properly, so I apologize for any mistakes.

noctux commented 4 years ago

Hey, nice work!

Well, writing code "blindly" has shown its disadvantages :) There was a small issue, as you had copied the "registerReloadConfig"-function but had forgotten to actually rename it. As indicated in #2, I've now switched over to using "modals" for preferences. If you are fine with my changes, I would be happy to merge it now. All seems to work as expected.

Btw: Building the code should be as easy as installing haskell-stack (in a recent version, sorry debian stable...) and runing stack build.

I've understood that you have now recreated the sound file yourself?

Beste regards, Simon

phikal commented 4 years ago

It was inevitable that I'd miss something, but at least it seems it wasn't too dramatic. And yes, I use debian stable, btw.

I've understood that you have now recreated the sound file yourself?

Yes, I hope it's ok. There's also a comment in the file's metadata saying it's public domain. I hope that's enough.

noctux commented 4 years ago

Yes, I hope it's ok. There's also a comment in the file's metadata saying it's public domain. I hope that's enough.

Sure, thanks!