search

noctux / adora-belle

A simple helpdesk tailored for use in remote-only university exercises
GNU Affero General Public License v3.0
2 stars 7 forks source link

Made activeRequests a be represented in JSON as an Object #5

Closed phikal closed 4 years ago

phikal commented 4 years ago

A revised approach to the issue from #4.

noctux commented 4 years ago

Hey, cool.

Just out of curiosity, what was the problem with the final version in #4 using DerivingVia? It should have resolved the problem as well, with less code? Does #5 provide more advantages beyond the nicer JSON layout?

phikal commented 4 years ago

Did DerivingVia solve the issue? I missed the last comment, but if that's enough, I don't see why this pull request should be preferred.

noctux commented 4 years ago

Yeah, it does. Ok, then maybe lets go with #4 then :)

Still, thanks four the contribution. Maybe you fall in love with Haskell on the way :)