search

nodeshift / nodejs-reference-architecture

The Red Hat and IBM Node.js Reference architecture. The teams 'opinion' on what components our customers and internal teams should use when building Node.js applications and guidance for how to be successful in production with those components.
https://nodeshift.dev/nodejs-reference-architecture/
Apache License 2.0
1.66k stars 120 forks source link

chore: move node_rdkafka to the top of the list in npcheck.json #166

Closed lholmquist closed 5 months ago

lholmquist commented 5 months ago

The npcheck ci has been failing when consistently when doing checks on the node_rdkafka library. For some reason, when moving that entry to the top of the list, it works.

mhdawson commented 5 months ago

@lholmquist you mentioned that changing the position in the file had let it pass? I think it would be better to do that than remove it since it seemed to pass when I ran locally instead of in the CI?

lholmquist commented 5 months ago

ah, right. good point. let me change that

lholmquist commented 5 months ago

@mhdawson PTAL