search

nodeshift / nodejs-reference-architecture

The Red Hat and IBM Node.js Reference architecture. The teams 'opinion' on what components our customers and internal teams should use when building Node.js applications and guidance for how to be successful in production with those components.
https://nodeshift.dev/nodejs-reference-architecture/
Apache License 2.0
1.66k stars 120 forks source link

chore: separate npcheck runs to their own workflow #99

Closed richardlau closed 2 years ago

richardlau commented 2 years ago

Run npcheck in its own workflow rather than part of the documentation StyleCheck workflow.

richardlau commented 2 years ago

Well https://github.com/nodeshift/nodejs-reference-architecture/runs/4290103480?check_suite_focus=true ran but fails. It's hard to see which are the two errors, although https://github.com/nodeshift/nodejs-reference-architecture/pull/98 should fix the one about nyc's license.

helio-frota commented 2 years ago

It's hard to see which are the two errors.

I agree, I saw the other error is about license as well. another day, I added the raw result in a txt file and started to delete other things until end up with 2 license errors

richardlau commented 2 years ago

Ah using the UI to search for "FAIL" gives: https://github.com/nodeshift/nodejs-reference-architecture/runs/4290103480?check_suite_focus=true#step:4:69

Checking license of argparse@2.0.1                                          FAIL

and https://github.com/nodeshift/nodejs-reference-architecture/runs/4290103480?check_suite_focus=true#step:4:1740

Checking license of caniuse-lite@1.0.30001282                               FAIL

corresponding to

(5): The module "eslint" depends on the "argparse@2.0.1" package which is under the non-acceptable license "Python-2.0".
...
(44): The module "nyc" depends on the "caniuse-lite@1.0.30001282" package which is under the non-acceptable license "CC-BY-4.0".

As previously mentioned, https://github.com/nodeshift/nodejs-reference-architecture/pull/98 should fix the caniuse-lite license error.

mhdawson commented 2 years ago

Ok, fixed up the npcheck file and allowed Python-2 just for eslint as it seems ok to me.