As a tool user I want a Template list view to have a quick overview of the actual existing template.

noi-techpark / it.bz.opendatahub.epaper.webapp

0 stars 5 forks source link

As a tool user I want a Template list view to have a quick overview of the actual existing template. #42

Closed sseppi closed 2 years ago

sseppi commented 2 years ago

For each template the view must show at least:

name;
description.

Options should be:

[x] an edit button
[x] a delete button
[x] a create button

UPDATE Some problems exist:

[x] We can have duplicate names currently, which is not correct... Names should be unique
[x] Clicking on "Show Content" shows "Cannot load preview" sometimes

UPDATE 2 The following is still not working:

[x] Delete gives "Failed to delete image" (tested with "Free SL")

See comments below

I tested it again and it always happens, when a template is associated to a display. So you would need to delete the display first, and then you can delete the template. But that is not what we want... we need to fix this.

Piiit commented 2 years ago

@SaimonasFOS @giovannigiannotta See UPDATE section in main comment

SaimonasFOS commented 2 years ago

@Piiit

We can have duplicate names currently, which is not correct... Names should be unique

Yes, will fix it in the future

Clicking on "Show Content" shows "Cannot load preview" sometimes

That is intentional, happens when the template has no background picture.

Delete gives "Failed to delete image" (tested with "Free SL")

Just checked that, happens when a Template is assigned to a Display, didn't catch this case in my testing. Will fix this soon.

Piiit commented 2 years ago

@SaimonasFOS Please see Update2 above

SaimonasFOS commented 2 years ago

@Piiit That's actually because the old template system (from the previous prototype) would assign a template to a display. So there's a display that still has a template related to it in your database. Current template system doesn't do that, it just copies background image and field information to a display based on a template. I just tested it to be sure and even after applying a new template to a display I was able to delete that template. In the future if we decide to change display content when changing the template, this relation will be needed again, so I left it there. But with the current workflow there should be no problem if you fix the database (I cannot do it since I do not see which display has that template assigned)

SaimonasFOS commented 2 years ago

Maybe it would be a good idea to wipe the whole database and start from scratch to avoid such bugs

Piiit commented 2 years ago

@SaimonasFOS I deleted the Free SL template and related display...

@sseppi Is it ok to delete the whole DB and refill?

Piiit commented 2 years ago

I close this issue in the meantime, lets open a new one if errors come up again during MVP2

sseppi commented 2 years ago

@sseppi Is it ok to delete the whole DB and refill?

I think tha we can clean everything and restart, or delete everything but the two real Totems

Piiit commented 2 years ago

I deleted some things with the GUI, everything seems to work as expected... so I did not touch the DB for the moment... let me know if a strange error occurs again, so I can purge the DB