noi-techpark / it.bz.opendatahub.epaper.webapp

0 stars 5 forks source link

As a NOI facility manager I want to be able to create, modify and delete new locations in order to be able to associate a display to a location. #43

Closed sseppi closed 2 years ago

sseppi commented 2 years ago

Each display location shall include the following information:

Please note that for each room there could be more than one display.

Options should be:

FEEDBACK AFTER TESTING

SaimonasFOS commented 2 years ago

This is completed, but I have to mention that NOI Places API returns a big amount of data (>2000 locations) and some of them have duplicate names but different codes. Filtering should be considered but at the moment I don't know what filtering criteria should be used.

sseppi commented 2 years ago

As discussed in the yesterday meeting, in order to reduce the number of choices for the final user, for the first MVP we suggest to follow the following solutions:

Here I post an example of call to get only Seminarroom or Meetingroom: https://mobility.api.opendatahub.bz.it/v2/flat/NOI-Place/?limit=-1&offset=0&where=smetadata.type.in.(Meetingroom,Seminarroom)

Finally for the next MVPs we can consider to allow add filter and search functionalities to allow the final user for example to see only the rooms of one single building or floor and/or search for a specific room.

SaimonasFOS commented 2 years ago

@sseppi I pushed the improved version of this feature to the api repository and the webapp repository.

sseppi commented 2 years ago

Super! So as soon as we have it online in testing I'll let you know! THX

Piiit commented 2 years ago

@sseppi It is online now, please test...

I have found already some issues, which I will add to the main comment above as to dos...

Piiit commented 2 years ago

@SaimonasFOS @giovannigiannotta There are some issue, please find them in the main comment... Thx

SaimonasFOS commented 2 years ago

@Piiit

https://github.com/noi-techpark/it.bz.opendatahub.epaper.api/pull/40 https://github.com/noi-techpark/it.bz.opendatahub.epaper.webapp/pull/81

Regarding room duplicates issue, after looking at the NOI Places GET request data I added two filters:

  1. active = true
  2. origin != "office365"

I don't really know what those two fields mean but that seems to help with filtering all duplicate rooms.

Piiit commented 2 years ago

@SaimonasFOS @sseppi Works