Enable importing .ksp files from folders (#400) broke some imports here (possible old math library related)

nojanath / SublimeKSP

Fork of Nils Liberg's SublimeKSP plugin. See README for details.

GNU General Public License v3.0

89 stars 18 forks source link

Enable importing .ksp files from folders (#400) broke some imports here (possible old math library related) #447

Open dxmachina opened 9 months ago

dxmachina commented 9 months ago

This commit specifically broke code that I'm maintaining here, possibly only related to the import of the old Big Bob math library. https://github.com/nojanath/SublimeKSP/commit/63a497fd51c7365b9a1d9c3c0685a077375b49b7

The line is simply: import "KSPMathV702.ksp"

Yields: Syntax error! (line 2279) ../common/external/KSPMathV702.ksp:4625

Release 1.17.0 is fine

mkruselj commented 8 months ago

Hmmm, I have some code that imports that same file in exactly the same way and it all works fine still... Weird!

dxmachina commented 8 months ago

Wow, really? Hmm.

It's obviously easy enough just to use the right commit when I need to get back to that code, but I figured a lot of people are maintaining code with the same library.

I did try a bunch of path simplifying to make sure it wasn't that. This was all on macOS.

Will take another look when I have some time.

mkruselj commented 7 months ago

Can you try with the very latest commit, please? Unsure if it'd fix but worth a shot I guess...

dxmachina commented 7 months ago

Unfortunately, still an issue with the latest commit here. When I find some time I will see about debugging it here as well.