search

nolanderc / glsl_analyzer

Language server for GLSL (autocomplete, goto-definition, formatter, and more)
GNU General Public License v3.0
156 stars 3 forks source link

Add more hover and completion tests #47

Closed automaticp closed 8 months ago

automaticp commented 8 months ago

Adds more tests for hover and completion on: buffers, images, sampler, arrays. Also fixes parsing of function overloads in test logic after the output was changed in cedaea8ad15e1bb73f01cd1da624ae5ab094e050.

Didn't catch any new bugs other than this minor one, but I wrote this for completeness sake.

If you have any ideas as to what else we should test, please feel free to give suggestions. I'm thinking of maybe testing hover/completion in presence of macros and includes next, but I'll likely start from the discussion in #30 just to settle on what to expect there.

We should probably close #32 if this is merged. All the unfixed bugs are still "documented" in tests with ExpectFail, so we can deal with them later.

nolanderc commented 8 months ago

We should probably close https://github.com/nolanderc/glsl_analyzer/issues/32 if this is merged. All the unfixed bugs are still "documented" in tests with ExpectFail, so we can deal with them later.

Yes, I think most "bugs" there are better thought of as weird but expected (and sometimes helpful?) behaivour.

Thanks a lot for writing all these tests! It's a heroic effort :smile: