search

nordtheme / emacs

An arctic, north-bluish clean and elegant Emacs theme.
https://www.nordtheme.com/ports/emacs
MIT License
491 stars 63 forks source link

improve ediff readability #107

Open ssnnoo opened 3 years ago

ssnnoo commented 3 years ago

Change colours to improve readability. Only colours for the regions that are not active are changed. Pls see also issue: 94

ssnnoo commented 3 years ago

to clarify, this addresses the issue of the poor readability of the light grey regions (not active) that can be seen in the first screenshot here ; these get nord colours (as in the second screenshot). it does not touch the active ediff region (red, green, yellow). Hope this makes it easier to understand.

ssnnoo commented 3 years ago

Is there any hope for this to go in? Or has this project been abandoned? Thx!

arcticicestudio commented 3 years ago

Hi @ssnnoo :wave:, first of thanks for your contribution :+1: Thanks for your patience, the large amount of tasks for the Nord project are really time consuming and my free time to work on all my OSS projects is limited. There are currently 60+ port project requests in the backlog and a massive amount of 350+ issues & PRs, not including support and help tasks per repository and requests from various communication channels like Twitter, the /r/nordtheme subreddit or just emails. The data transition of all port projects to the official website and documentations is still a focused job to finally reduce the maintenance overhead, create a „single source of truth“ and increase the overall project quality :octocat:

I'll review your PR as soon as there is time again to process the queue. Even though some changes might appear to the outside as if they are small, but as a maintainer it is always important to ensure that it matches the project goals and not only a single-user use case. It also requires some research about backwards compatibility because not every user uses the latest version of an application or package/plugin/addon.

ssnnoo commented 3 years ago

Absolutely, it is just that the last commit in the nord-emacs was last year, while for other nord reps this is not true. Many thanks.