search

nordtheme / emacs

An arctic, north-bluish clean and elegant Emacs theme.
https://www.nordtheme.com/ports/emacs
MIT License
488 stars 63 forks source link

Open to a formatting fixup PR? #120

Open TRSx80 opened 1 year ago

TRSx80 commented 1 year ago

As I was working on #119, I noticed that there is a bit of weird indentation here and there, some extra whitespace, etc.

Now that I think I got the hang of this, there are a few more packages I will probably eventually submit PRs to support.

But that would be easier if I could use Lispy freely as I normally do when editing ELisp (which I do quite a lot of). The problem is that Lispy will automatically reformat things to proper ELisp conventions as you go along, for example fixing indentation when you hit RET at end of line, etc. Once I realized what had happened, I had to turn it off and undo lest I wreck the current (incorrect) formatting of some (large?) part of the file nord-theme.el.

So I thought maybe it would be best to submit 1 PR first cleaning up the formatting, before proceeding. I mean, if that sounds like a good idea to you?

What do you think?

TRSx80 commented 1 year ago

After opening this issue, I was looking around a bit more and I started to realize that you seem to be a bit overwhelmed with the volume of issues and PRs, etc.

I am not bringing this up to harangue you about that, quite the contrary. And congratulations on the success of the project. :wink:

However I think I shall proceed by simply sending separate PRs for whatever packages I have in mind (so far Gnus and kpm-list, maybe others later). That way people can just apply those patches (independently if they wish) until you can get caught up or get some help or whatever.

I guess I leave it up to you if you want to keep this issue open I am happy to work in it later whenever you are ready. Or close it for the time being.

Cheers!