search

nordtheme / emacs

An arctic, north-bluish clean and elegant Emacs theme.
https://www.nordtheme.com/ports/emacs
MIT License
488 stars 63 forks source link

Support for ediff #94

Open Linuus opened 4 years ago

Linuus commented 4 years ago

It looks like there is no support for ediff yet. Here's a list of faces that zenburn uses: https://github.com/bbatsov/zenburn-emacs/blob/master/zenburn-theme.el#L524-L540

arcticicestudio commented 4 years ago

Hi @Linuus :wave:, thanks for your contribution :+1: I've added it to the backlog, but anyone can feel free to submit a PR for it 😄

ssnnoo commented 4 years ago

Getting ediff to work with only 16 colours is a big challenge because the default ediff keeps the syntax highlighting and just overlays red etc. What could be done instead is to change the foreground to a constant color (also done in other themes, e.g. solarized) and highlight changes in bold. See attached screenshots. Any opinions regarding this?

nord_ediff_old nord_ediff_new nord_ediff_new2
Linuus commented 4 years ago

Personally I like the default style more I think. It's a bit easier for me to see what has changed, but maybe I would get used to the other style :)

What about using the default colors but make them a bit lighter/transparent and highlight the inline changes with regular Nord colors (so it more resembles the default ediff but it's a bit more Nord styleish)?

Also, just fixing that hard to read grey highlighting makes a huge difference! :)

ssnnoo commented 4 years ago

still there are occasions where the default colours do not provide great readability. but overall maybe a good compromise?

newx
ssnnoo commented 4 years ago

or like this, but then again we lose the syntax highlighting in the active diff region. personally I don't mind as this is not super useful anyway.

new2