Open TRSx80 opened 4 years ago
Hi @TRSx80 :wave:, thanks for your contribution :+1: Again a great and detailed documentation 😉
Adding support for other packages is always welcome.
Your prototype already looks great. The only part I'd change is to use nord8
instead of nord7
for the section headings since it's the main accent color.
Feel free to submit a PR so we can review and merge it into the theme. The color palettes are also already exist as constants so you can simply reuse them.
Regarding the "are there any other" question: Everyone who contributes to a open source project is part of it, regardless of whether it's code via a PR, issues/reports or commenting on issues. This account name might be indeed a bit confusing, but you can find me at @svengreb 😊 Some background info about this is documented on my sponsors page, but there will be many more details in an upcoming information article/blog/Reddit post as well as on my website (when I finally find some time to build it 😆)
The only part I'd change is to use
nord8
instead ofnord7
for the section headings since it's the main accent color.
I actually played with that quite a bit, IIRC. If you look closely, there is some differentiation between regular directory font, old-path-face
, etc. and I think I simply ran out of options/colors, or I couldn't get it to "look right" or... differentiation, or... something (it's been a little while now)? Maybe it was that I started off by matching the default dired
(directory editor, the Emacs file manager) directory color, for consistency reasons. Anyway, if/when I circle back to this, I will definitely take your feedback into account on my second pass, so thanks.
Also, after I posted this, I realized that perhaps the better approach would be to talk to the kpm-list
creator about maybe re-mapping his hard-coded colors to the "standard" alias ones in Emacs so they would automatically pick up whatever theme the user enabled. Because most packages in Emacs seem to do it that way. The couple times I changed themes the last few years, however, that package was always the only one standing out with it's own hard-coded separate theme.
Failing that, I will come back and re-visit this, perhaps submit a PR, etc. In the meantime, anyone needing it is free to copy-paste what I posted and use it in their init file. Everyone wins. I just prefer to take the time and do the "right" approach. Cheers!
Good day!,
I have really been enjoying Nord! Now I am at the point of starting to tweak little things here and there.
One of the most glaring things (at least on my own setup) that was standing out (theme wise) was
kpm-list
which is an intelligent grouped buffer list, that I have been using for some years now and couldn't live without. But the default colors were absolutely clashing with Nord. It was jarring, and that is a buffer that I use quite a lot.So last night, I decided to sit down and fix that. I think that what I came up with was pretty workable:
All the credit goes to @arcticicestudio (and others (are there any others?)) for picking out a really nice color palette and writing some great documentation which makes it really easy for even a total sperg like myself to adapt/apply them to new situations and places. Thanks again for all your effort. And for sharing. :beers:
I had made a thread over there at
kpm-list
last night but figured I would make another here, too. I can't imagine that the union in the Venn diagram between the two projects is a very large number of people :smile: but you never know. Anyway a little cross pollination / promotion is never bad for great F/LOSS projects anyway. :wink: Maybe some people finds one or the other project useful.I am not even sure I did this "properly" (any Emacs theming tips are welcomed!) but I got it to work by putting the following in my Emacs init to override the defaults.
Of course you can set the colors directly by hex value, but I find this way of aliasing them easier to work with. Especially when "playing around" and tweaking things. Just make sure you assign the color palette variables (
nord0...16
) earlier on in the init loading then when you need to use them (in case you end up using them in multiple places to override other things as well, like I do).