search

northem / northem-atom-syntax

A north-bluish, dark clean and elegant Atom syntax theme.
MIT License
5 stars 0 forks source link

No markup for unsupported language #1

Closed JustusAdam closed 9 years ago

JustusAdam commented 9 years ago

I was trying out this theme and opened a Haskell source file and there seems to be no markup for it.

I have searched the source and there's at least a 'fallback.less' file specifying some markup so why is there no markup for Haskell? I know it is not a supported language but the editor is attaching the right classes to the code pieces and I am wondering why they're not getting highlighted with the fallback.

I've attached a screenshot for your convenience.

screen shot 2015-07-29 at 00 48 15
arcticicestudio commented 9 years ago

This is not an error, but by design. Most syntax themes define only one file including all classes applied to all languages. But this way, there's no kind of "color logic" caused by the different language syntax. I want to have one ruleset including all classes for each language to define it as explicit as possible.

In addition to the use of my own personal color scheme, this is one of the reasons why I started to write this syntax theme. Every language gets its own file/ruleset to ensure a continuous "color logic".

I will add as much language syntax-highlighting as possible and I'm always grateful for help and advice because I do not know every programming language. Will add Haskell support to my TODO list for the next update =)

By the way, most of my UI & Syntax themes are still in 'indev' development state (version identifier MAJOR is 0) and there will of course be more updates, but I have not had much free time to work on them.

arcticicestudio commented 9 years ago

@JustusAdam I'll try to patch Haskell support today, but actually can't get the language-haskell package working (no markup appearing at all :confused:). Have you tried it using the fallback.less and if so, has it worked with it?

EDIT: Fixed it some hours ago. The solution is too embarrasing to post it... :no_mouth: Hint: Always make sure to work in the repo located in the atom folder to see live results :laughing:

arcticicestudio commented 9 years ago

Please ignore the automatic issue reference, copied the wrong issue into the CHANGELOG :unamused: , but this one is also fixed in 0.4.0.

JustusAdam commented 9 years ago

Haha :smile: thanks for adding this.

JustusAdam commented 9 years ago

Looking pretty good too.