nosoop / SM-TFCWXBaseAttributes

Implementations of Custom Weapons 3 properties as custom attributes.
GNU General Public License v3.0
4 stars 5 forks source link

View / worldmodels broken as of 2021-06-22 update #4

Closed sticks-stuff closed 2 years ago

sticks-stuff commented 3 years ago

Weapons are invisible

nosoop commented 3 years ago

Thank you for the report — have you updated the gamedata for tf2utils? The recent game update caused some function calls to not be where tf2utils expects them, and the viewmodel functionality depends on tf2utils to handle that.

This may be related to nosoop/SM-TFCustomWeaponsX#23.

sticks-stuff commented 3 years ago

Oops! I'm super sorry! Yep that fixed it, thank you!

sticks-stuff commented 3 years ago

Wait, nevermind lol. Updating the gamedata fixed sm_cwx_equip not working but it didn't fix invisible viewmodels. The worldmodel is correct however. image

nosoop commented 3 years ago

Interesting; I'll go ahead and reopen this. Quick test on my machine seems like they both (viewmodels and worldmodels) work as expected, but I've had a separate report sent privately so it doesn't seem to just be a one-off problem.

It uses the same wearable functionality as the shield equips (in CWX), so they (CWX and viewmodel overrides) should either both work or not.

chosenbill commented 3 years ago

I thank noscoop for linking me to this. I still use CW3 and my situation is similar but worse as in even the hands dont show up, but i also tried using https://forums.alliedmods.net/showthread.php?p=2742241#post2742241 which uses noscoop's Custom Attributes framework and that resulted in me getting same results as sticks-stuff. And unfortunately even after updating the gamedata it is the same.

nosoop commented 3 years ago

Yeah; I can't reproduce this issue at all with assets I have on hand — I can see custom viewmodels without issue on both Windows and Linux servers.

Attached is a CWX configuration with one all-class melee item with a stock replacement model; please test it and let me know whether or not you can see the item and if there are any error messages printed in server / client consoles.

viewmodel_test_item.txt

sticks-stuff commented 3 years ago

This works but sometimes it turns red for whatever reason

image image

nosoop commented 3 years ago

Ah, yeah; the lighting issue affects the mainline branch (there's a lighting-quirk-fix branch which backports the fix from @Zabaniya001's plugin, but it has its own share of quirks).

Because the arm and weapon do show up, it looks like the wearable system and viewmodels work, so this shouldn't be an issue with the plugin itself.

It could be a change related to loading custom models; I did notice a few filesystem-related changes landed with the update. Are the models on your system located under tf/downloads/models, or were they installed within tf/custom or tf/models/? All of mine are in tf/downloads/models.

sticks-stuff commented 3 years ago

They're in tf/downloads/models

chosenbill commented 3 years ago

I had to run somewhere last time so had no time to experiment with things, but after trying the module did work with cw3 still with the problem that sticks-stuff stated but I was having that before anyways glad the models show up at all. If there is a fix for it that would be dope but I'm content with result either way.

Thanks!

nosoop commented 3 years ago

Are there still issues with viewmodels not displaying, @sticks-stuff? It looks like @chosenbill somehow managed to resolve the issue on their end.

I'm unfortunately still unable to reproduce this visibility on either the main or lighting-quirk-fix branches.

sticks-stuff commented 3 years ago

Yep, custom models still appear invisible for me, using the exact same settings as before the update when it was working

nosoop commented 3 years ago

It does sound like a game-related change; could you attach a known broken configuration (with any necessary models) for me to look into?

sticks-stuff commented 3 years ago
    "stick.SwordNormal"
    {
        // here's a condensed example
        "name"          "wii sports"
        "inherits"      "The Eyelander"
        "keep_static_attrs"     "0"
        "attributes_game"
        {
            "deploy time decreased" "0.005"
            "apply look velocity on damage" "100"
        }
        "attributes_custom"
        {
            "worldmodel override"   "models/wiisports/sword.mdl"
            "viewmodel override"    "models/wiisports/sword.mdl"
            "clientmodel override"  "models/wiisports/sword.mdl"
        }
    }

wiisports_sword.zip

nosoop commented 3 years ago

The model replacement test item indicates that the plugin is working as intended on your end, and I don't have any problems with the config or the model either.

That said, maybe remove worldmodel override and viewmodel override? clientmodel override is intended a shortcut for both, but I'm not sure why they would conflict. It does look like specifying worldmodel override alone causes viewmodels to be hidden; that may be a change that started with the update or something that was present before.

20210702002414_1

sticks-stuff commented 2 years ago

Went back to this after months of abandoning this project, turns out I just forgot to add a crucial file to my downloads table… whoops…

Yeah, sorry about that, works perfectly now! Thank you very much for all your work on this project!

nosoop commented 2 years ago

Thanks for following up! I'll add a note in the README indicating that the plugin doesn't perform any download table management in case someone else runs into a similar issue in the future. It's actually already there and I forgot about it, oop