search

notablackbear / poe_qolV2

52 stars 34 forks source link

Issues with non-standard Documents folder location #4

Open rorshan opened 4 years ago

rorshan commented 4 years ago

My "My Documents" folder is not located at its default location on my OS drive. It's instead on another drive. This is possible natively in Windows 10 using the library system and its relocate option.

When I'm in %userprofile% (which is C:\users\myusername on my system) in Explorer I have a Documents folder which is just some kind of symlink to the actual location which is D:\myusername\Documents. The actual C:\users\myusername\Documents folder is essentially empty

Path of Exile (and most well-behaved programs) support that relocation since it's been a standard Windows feature for years now.

When I try to launch the app as is it crashes after loading for a few seconds. I tried to copy my PoE Documents folder to C:\users\myusername\Documents\My Games\Path of Exile and then the program launched. Unfortunately PoE looks at my real documents folder (as it should) and not where your app looks at.

I managed to make it work by putting the full filepath inside the filter variable in Setup.ini. Unfortunately this is not obvious at all since the only way to make it work is by NOT putting quotes around the filepath (even though it should be standard on filepaths that use spaces) EDIT: It seems that workaround only works the first time I launch the app. It seems that when launching the app it modifies the filter file in some way. The next launches are then crashes. The only fix is to either re-copy the POEQOL_Base.filter file or delete it from the PoE filter folder

I see two ways to fix this issue

  1. Change how you allow paths to be specified in Setup.ini to make it fully supported. And if you do, specify how full filepaths should be formatted
  2. There are some ways to find out where the Documents folder is located. I'm by no means an expert on this part of Windows, and I have no idea of how your program works but I know that information can be accessed through a simple lookup in the registry or a simple Powershell command. You can find some info here
NickReinlein commented 4 years ago

@rorshan Thanks, this helped me resolve my issue: different drive, different error, same root cause https://github.com/notablackbear/poe_qolV2/issues/5

notablackbear commented 4 years ago

Thanks @rorshan . There's two errors going on.@LoneWolfHowl is correct for the second one. That files has been updated to include the missing line, so try to re-download the files

As far as the first error, yes as mentioned in the Setup file, it will only look for the filter folder in the default location, which is the 'C' drive. It is not a polished app and time has been limited, so edge cases like this haven't been properly handled. Thank you for the report, I'll consider a better way to handle this. If using the full path works for you in the time being, keep going with that. Thank you for the report.