Open 0xdavidel opened 3 years ago
A bug I found - Accidentaly I am using os.exit instead of using sys.exit.
this results in an error instead of a clean exit, but it doesn't break the functionality of the code, fixing it now
So i'm trying to test this branch out, but i'm having a ton of trouble closing the program since the extra thread is not being handled on close. I am trying to figure out how to handle it, but you might be able to quicker.
Thats odd, the thread is set to daemon mode, one sec, ill reimplement the function so that it doesn't sleep for 10 seconds
Try it now, it now sleeps only half a seconds and each time it checks if enough time elapsed from the previous stash_sync check
Nevermind, I see what you mean, the gui closes but the python keeps on running, ill see what I can do
Added a way to close it, not the best code but the whole GUI side of the app still needs a refactor so that the tkApp only handles the GUI and separate out the logic into a different class and functions that are not inside the GUI class.
So i've been testing this out, and it works really well for the most part. I think it might be good to keep perfecting it in another branch before merging into master though? Here's a couple of notes:
I think a couple of these are easy to fix, like the text.
This is probably too many changes for a single pull request, got carried away, whoops Here is the gist: