notablackbear / poe_qolV2

52 stars 34 forks source link

poe_qol overwrites externally updated filter #62

Open Irfy opened 3 years ago

Irfy commented 3 years ago

Instead of updating just the section designated for the chaos recipe at the top of the filter, poe_qol seems to cache the whole filter on startup and overwrites it fully every time it refreshes. This makes external update of base filter impossible while poe_qol is running.

Workaround: shut down poe_qol before updating filter, update filter, restart poe_qol.

Ideal solution: do not cache the external file, read-update-write every time. Alternatively, cache the file, but also remember its modification time, compare the modification time to last write, if not equal, read-update-write. If equal, overwrite, and update remembered modification time.

0xdavidel commented 3 years ago

This is exactly how the newest version was implemented, if this is a major concern for you I would suggest executing the python script directly instead of the executables as they are not up to date anymore.

A better solution for executing and making sure the code is up to date will be developed soon