search

notapixelstudio / starship-olympics

A fast-paced local party game with starships that battle in a 2d top-down arena
https://notapixel.itch.io/starship-olympics
Other
511 stars 46 forks source link

German umlauts do not work in some menu buttons. #1069

Closed tafode closed 1 year ago

tafode commented 1 year ago

In some of the option menus the back button doesn't show umlauts. e.g. in the options menu, the button only shows. "ZURCK" instead of "ZURÜCK". Same issue in the audio menu. I'm new in the Godot Engine, so I'm not totally sure, but I guess it has todo with a different font which does not support umlauts.

Option Audio

salvob41 commented 1 year ago

Thank you for the report.

Yes, it has to do with the font used that does not have the special character.

The localization is still the one from the previous release so it's missing a few labels and wasn't test properly.

We need to work on it and fix it. Should be enough to use and decide a fallback font.

salvob41 commented 1 year ago

https://github.com/godotengine/godot/issues/8998#issuecomment-544190708

Relevant

tafode commented 1 year ago

You're welcome. I have also tried to fix/add some of the missing strings in the german localization file with the pull request here . But I did realize that the file is not uptodate, e.g. Start instead of new game... So I wasn't sure what is still used and what not.

salvob41 commented 1 year ago

True, a lot of different improvements have been added in starship Olympics. And we haven't yet focus on reporting those changes in localization, also because they might soon change again depending on the feedback and clarity perceived by users.

Thanks, this is important for us.

tafode commented 1 year ago

Hi again,

The issue with the menu buttons is fixed. But I just noticed that there is another place where the umlauts are not displayed correctly.

CharacterScreen

The name of the species should most likely be no problem, as I guess they will stay the same as the english one. But the description of the Auriels has already umlauts in the german text. Should be "überfürsorgliche Hirten". I hope this is something which don't cause too much effort.

salvob41 commented 1 year ago

True, I made a fix for this, but we should keep checking since the resources for the fonts contains information different depending on which label we are dealing with. I know that in Godot4 they changed this behaviour. So next release we will update this specific issue, but I'll keep this open until we add fallback to ALL labels (and buttons)