nova-framework / framework

Demo application using Nova - this is an extensive playground, use "app" repository for real applications.
http://novaframework.com/
MIT License
418 stars 211 forks source link

potential for v4? #986

Closed dcblogdev closed 8 years ago

dcblogdev commented 8 years ago

I know I've been the biggest support on staying v3 but with the constant updates happening I feel it would be better to jump to v4 now and separate the application into app and system to the framework can be updated from a composer update.

thoughts?

LuckyCyborg commented 8 years ago

:+1:

dcblogdev commented 8 years ago

https://packagist.org/packages/nova-framework/bare-app

LuckyCyborg commented 8 years ago

Thanks!

LuckyCyborg commented 8 years ago

@daveismyname

Username for 'https://github.com': LuckyCyborg
Password for 'https://LuckyCyborg@github.com': 
remote: Permission to nova-framework/bare-app.git denied to LuckyCyborg.
fatal: unable to access 'https://github.com/nova-framework/bare-app.git/': The requested URL returned error: 403

I need full access there!

dcblogdev commented 8 years ago

I've just added you to there now.

LuckyCyborg commented 8 years ago

Thanks!

LuckyCyborg commented 8 years ago

@daveismyname You can test the preliminary App with vendor based System. This one:

https://github.com/nova-framework/app

Oh, and someone maybe will raise the hand to update the Language files from App, merging the information from Welcome.php to message.php

There will not be available that old style for translations. :smirk:

dcblogdev commented 8 years ago

OK that installs perfectly threw me at first with the dev address being different but works good.

The language switcher isn't changing language though.

LuckyCyborg commented 8 years ago

The language switcher isn't changing language though.

It change, but someone should update the Language files. Only the new style APIs available there, you remember?

Partially I updated Romanian, for tests.

BTW, is Nova Testing, after all. You expect me to give you the version four on a half day? :smirk:

dcblogdev commented 8 years ago

ah ok I'm not familiar with the new style language, is that the message.php files?

dcblogdev commented 8 years ago

Personally I won't be using them but I'm sure others will be.

LuckyCyborg commented 8 years ago

ah ok I'm not familiar with the new style language, is that the message.php files?

Yes. This one. The Key is the original string, the Value is the translated string.

LuckyCyborg commented 8 years ago

Now going to job. I'll be back!

dcblogdev commented 8 years ago

Ok thanks 👍

ghost commented 8 years ago

@LuckyCyborg

It change, but someone should update the Language files. Only the new style APIs available there, you remember?

I'll update them.

LuckyCyborg commented 8 years ago

@Kingorgg Thanks, Daniel!

LuckyCyborg commented 8 years ago

@daveismyname and @Kingorgg I will leave to you the decision how will be implemented the Default (and Only) Template on https://github.com/nova-framework/bare-app

My suggestion is to use the CDN for Assets, or even direct Assets shipping, but no Vendor one.

jimgwhit commented 8 years ago

@daveismyname the demos are important for new users also who may not know how to use the features yet. Having a blank framework without at least a demo leaves people in the dark.

LuckyCyborg commented 8 years ago

@jimgwhit

he demos are important for new users also who may not know how to use the features yet. Having a blank framework without at least a demo leaves people in the dark.

There we will completely agree! :+1:

And, that's WHY we will ship two APPs for Nova Four: one with all shiny demos, just like on Nova Three, and one stripped bare, for Gurus.

jimgwhit commented 8 years ago

@LuckyCyborg if I want to use the database helper in version 4 could you please tell me how to implement it? Surely version 4 will be flexible enough to use custom helpers etc.

LuckyCyborg commented 8 years ago

@jimgwhit Just adapt it for App\Helpers.

Eventually, create a Helpers which add the Wheres on top of Database API, which give you long queries. No need to respect 100% the old helper.

jimgwhit commented 8 years ago

@LuckyCyborg said

Eventually, create a Helpers which add the Wheres on top of Database API

Could you give a short example of what this would look like because now all is integrated. Not the where thing but how to go about the integration. Including a helper won't be possible because that will be in vendor I'm guessing so the integration I'm not sure where and how.
But since system is install now via composer any updates will Wipeout any customizations. Same thing for a Doctrine d-bal usage let's say someone wants to use that where would they implement it to use?
Prior versions was straightforward to implement, almost need access to system to do this correct. System is installed via composer now that takes out flexibility doesn't it?
Don't understand why it's a locked out system now to other databases.

LuckyCyborg commented 8 years ago

@jimgwhit Come on! Now I should write custom Helpers for you?

AdminUI commented 8 years ago

When can we start testing with it ?

LuckyCyborg commented 8 years ago

@southcoastweb

When can we start testing with it ?

It is alive. Use:

git clone https://github.com/nova-framework/app.git novatesting

And go ahead! :smile:

dcblogdev commented 8 years ago

just installed from composer command using app:

composer create-project nova-framework/app -s dev

When I run it:

Cannot use Nova\Core\Template as Template because the name is already in use
dcblogdev commented 8 years ago

In novalocal/app/vendor/nova-framework/system/src/Support/Facades/Response.php

LuckyCyborg commented 8 years ago

OK. Thanks

LuckyCyborg commented 8 years ago

Please update the composer

LuckyCyborg commented 8 years ago

@daveismyname BTW, to avoid delays on packagist updates, I suggest you to use git cloning for now.

dcblogdev commented 8 years ago

that worked ;)

AdminUI commented 8 years ago

Cannot use Nova\Core\View as View because the name is already in use. /home/nova4/vendor/nova-framework/system/src/Support/Facades/Response.php

AdminUI commented 8 years ago

is that the one you just done? oops

LuckyCyborg commented 8 years ago

Do not use composer, use git cloning

Dave know why, the composer give delay.

LuckyCyborg commented 8 years ago

snapshot22

snapshot23

That's https://github.com/nova-framework/app

AdminUI commented 8 years ago

nice 👍 Im just uploading the bare-app right now to my test server.

LuckyCyborg commented 8 years ago

Bare App is not ready!

AdminUI commented 8 years ago

Call to a member function withContent() on null lol i just found that out

LuckyCyborg commented 8 years ago

You believe that I will give yours the Nova 4 on one freaking day? :smile:

AdminUI commented 8 years ago

the days not over.. 😃

LuckyCyborg commented 8 years ago

But the full App is working. Good to test it.

AdminUI commented 8 years ago

i knew you could type quick if i remove the line withContent() from routes it loads fine to a blank screen Ill remove it and do the full version then

LuckyCyborg commented 8 years ago

@southcoastweb At Bare App I wait @daveismyname and @Kingorgg to do something with the Default Template which should not rely on Vendor, or we will add 12MB to fat.

LuckyCyborg commented 8 years ago

This is Bare App, with Vendor shipped Bootstrap 3 for the Default Template

snapshot24

Amin-stefan commented 8 years ago

I think we don't any controller or welcome page or template for Bare App. People must write own code there with Bare App we can update our project with a simple pulling

LuckyCyborg commented 8 years ago

@amiroperator There is no controller beyond the language changer.

The homepage is generated by Routing, directly.

Yet, for now we need a template, to show the Errors Pages. Which are themed.

dcblogdev commented 8 years ago

I'll use a CDN for bootstrap using a single layout file keep is stripped down with a welcome controller. it should come with something to see even it it's tiny.

LuckyCyborg commented 8 years ago

@daveismyname No Welcome Controller there, just a Route:

Router::any('', function() {
    $view = View::make('Default')
        ->shares('title', __('Welcome'))
        ->withContent(__('Yup! It works.'));

    $template = Template::make('default')->withContent($view);

    return Response::make($template);
});
dcblogdev commented 8 years ago

ah that will work.

Amin-stefan commented 8 years ago

You don't need all file in default except default.php. Why you are keeping them ?