search

nova-framework / framework

Demo application using Nova - this is an extensive playground, use "app" repository for real applications.
http://novaframework.com/
MIT License
418 stars 211 forks source link

potential for v4? #986

Closed dcblogdev closed 8 years ago

dcblogdev commented 8 years ago

I know I've been the biggest support on staying v3 but with the constant updates happening I feel it would be better to jump to v4 now and separate the application into app and system to the framework can be updated from a composer update.

thoughts?

dcblogdev commented 8 years ago

I said just a single layout file did I not?

LuckyCyborg commented 8 years ago

@daveismyname I updated the Bare App to (momentary) use the Vendor shipped Bootstrap 3, to see it working.

The Template is in yours hand.

dcblogdev commented 8 years ago

OK I'll update it, thanks.

LuckyCyborg commented 8 years ago

@daveismyname :+1:

Amin-stefan commented 8 years ago

Is that custom necessary you didn't remove?

dcblogdev commented 8 years ago

I haven't uploaded my changes yet, none of them have been removed on the repo yet.

LuckyCyborg commented 8 years ago

I removed footer/header from both apps

dcblogdev commented 8 years ago

I'm working on the bare-app repo theme on my local will upload it in a few moments.

LuckyCyborg commented 8 years ago

OK! I'm curious about your take! :smile:

LuckyCyborg commented 8 years ago

And yeah, there is no need for Custom Layout and its RTL counterpart...

dcblogdev commented 8 years ago

agreed.

dcblogdev commented 8 years ago

Is the language change needed on the bare? as standard?

dcblogdev commented 8 years ago

I ask for others, myself I don't need it.

Amin-stefan commented 8 years ago

I don't need it too

ghost commented 8 years ago

No, I don't think it should be needed on the bare-app. If the user wants it, they should be able to add it themselves.

dcblogdev commented 8 years ago

maybe we should leave that for the full app install?

Amin-stefan commented 8 years ago

Let people write their code

dcblogdev commented 8 years ago

OK.

LuckyCyborg commented 8 years ago

I have intention to write RESTful APIs with the Bare App, then I guess not.

ghost commented 8 years ago

What about removing the models from bare-app as well?

Amin-stefan commented 8 years ago

What about removing the models from bare-app as well?

agreed

LuckyCyborg commented 8 years ago

Are used by Auth API, the User one. The Role is on Relation with the first.

Then I suggest to not remove them or Auth will go nuts.

ghost commented 8 years ago

Okay, no problem :+1:

dcblogdev commented 8 years ago

There is a Welcome view inside Emails is that still needed I assume it's not?

dcblogdev commented 8 years ago

I'll leave the Auth email views for anyone who wants to use the Auth as is.

LuckyCyborg commented 8 years ago

Yeah, that was a test.

LuckyCyborg commented 8 years ago

But app/Views/Emails/Auth are part of Auth API.

dcblogdev commented 8 years ago

Yes I've left them.

dcblogdev commented 8 years ago

by the way does anything call app/Views/Default.php?

LuckyCyborg commented 8 years ago

You deleted the Language from Template? WHY?

dcblogdev commented 8 years ago

I thought that was not being included?

LuckyCyborg commented 8 years ago

That Language folders are expected by Language API, and they are not optional.

You ship a Template (or Module), they should have that Langauge folder. even if the contained messages are empty. Because Nova 4 is multi-language and multilingual.

dcblogdev commented 8 years ago

ah OK I'll add it back.

LuckyCyborg commented 8 years ago

OK. Thanks.

dcblogdev commented 8 years ago

OK I think that does it, I did re-add the language changer since the languages are there.

LuckyCyborg commented 8 years ago

@daveismyname Please use scripts/makelangs.php to update the Language files. Contains stalled strings.

dcblogdev commented 8 years ago

I ran that saw output in terminal but nothing new to commit. No changes detected.

LuckyCyborg commented 8 years ago

OK

LuckyCyborg commented 8 years ago

@daveismyname See that I updated the Language files for the Default Template

jimgwhit commented 8 years ago

@daveismyname and @LuckyCyborg Why not do away with the bare repo and have the one with the stuff and the demos and just have a script that will delete all unnecessary things if someone chooses to run the script wouldn't this be much simpler. Maybe just whip out a CLI script. This two repo thing may get out of hand quickly.

dcblogdev commented 8 years ago

because I want a bare bones one, that requires me to do nothing to be ready to go with it. You don't want it, fine ignore it.

dcblogdev commented 8 years ago

This two repo thing may get out of hand quickly.

The bare bones should not need to be touched (or very little) so I don't see how.

LuckyCyborg commented 8 years ago

@daveismyname

The bare bones should not need to be touched (or very little) so I don't see how.

Yep. There I agree. The bare bones application need to be adjusted maybe/only when there are changes on Boot Stage or are introduced/removed configuration options.

In other hand, I prefer to treat the both applications equal. The full fledged one is very useful for development and for beginners to have a quick look over, while the bare bones is very valuable for the Gurus wanting full customized apps.

BTW, no more dumping whatever variables in the Layouts or Views. The Rendering API will not nurse that anymore, then the recommended way to put optional variables on those files is:

echo isset($js) ? $js : '';

I know, whaaa! that complicated the code!, but this will stop the Exception Handling Service to yell for undefined variables, and after all, this is the correct way to do the things.

LuckyCyborg commented 8 years ago

@daveismyname Oh, a idea:

How we go breaking API on a new major versio, I see no sense to ship two identical facades to Router Service.

My proposal is to continue to ship only the Facade called Route, just like Laravel, and to remove the Facade called Router.

dcblogdev commented 8 years ago

OK so the only change would be when setting a route that Route:: would be used instead of Router:: right?

Yes I can agree with that, I'll make a note to update the v4 docs when I start them.

LuckyCyborg commented 8 years ago

@daveismyname Yes, this is the only change. And adjusting your generator. Which I made it.

jimgwhit commented 8 years ago

@daveismyname okay earlier I said

Why not do away with the bare repo and have the one with the stuff and the demos and just have a script that will delete all unnecessary things if someone chooses to run the script wouldn't this be much simpler. Maybe just whip out a CLI script. This two repo thing may get out of hand quickly.

Could you do it the opposite just have the bare bones, and maybe two composer files one could be named composer.bare, other composer.app time for install rename one of them to composer.json.
Just looking for a way to make it easy because I know two repos will quickly become a nightmare.
Anyway some idea like this just to have one.

dcblogdev commented 8 years ago

Jim move on, you asked it's been answered. Lets not have 30+ posts on something that does not need discussing it's done.

jimgwhit commented 8 years ago

@daveismyname did you read the whole thing?

LuckyCyborg commented 8 years ago

@daveismyname Then, the Nova's Artis... err, Forge is functional. :smirk:

I nuked the old CLI and in the next days I will re-implement Forge the commands given by previous CLI and maybe I will go beyond.

To note that was need to update the Boot Stage and Configuration, even public/index.php, on both APPs.