search

np-guard / vpc-network-config-analyzer

A tool for analyzing the configured network connectivity of VPCs as specified by various VPC resources
Apache License 2.0
8 stars 0 forks source link

fix current tests with overlapping address prefixes + Remove function #878

Closed olasaadi99 closed 1 month ago

olasaadi99 commented 2 months ago

fix current tests with overlapping address prefixes + Remove function validateAddressPrefixesExist()

zivnevo commented 1 month ago

How did you determine the address_prefixes field of each VPC? Is this based on a new run of the collector, manually from subnet info, something else?

olasaadi99 commented 1 month ago

How did you determine the address_prefixes field of each VPC? Is this based on a new run of the collector, manually from subnet info, something else?

all of them based on a new run from terrafotm examples except for tgw_larger_example based on subnet info (address_prefixes for this examples from terraform examples are with overlapped, and all of the tests assumes that it is not overlapping and use the subnet cidrs as AP)