search

np-guard / vpc-network-config-analyzer

A tool for analyzing the configured network connectivity of VPCs as specified by various VPC resources
Apache License 2.0
8 stars 0 forks source link

Consider merging lint in the general flow as an additional usecase #887

Open ShiriMoran opened 1 month ago

ShiriMoran commented 1 month ago 
          Function name is confusing - lint doesn't really have use cases.

By the way, why isn't "lint" a separate use case?

_Originally posted by @zivnevo in https://github.com/np-guard/vpc-network-config-analyzer/pull/875#discussion_r1771046998_

ShiriMoran commented 1 month ago

Possible; we will have to add []linter to the OutputGenerator

ShiriMoran commented 1 month ago

Integrating lint in the general flow can be done only once https://github.com/np-guard/vpc-network-config-analyzer/issues/638 is solved.

  1. Lint strongly relies on vpcmodel structs
  2. The Output generator also resides in vpcmodel
  3. vpcmodel is kindda spaghetti
  4. Lint resides in a dedicated package, not vpcmodel
  5. Integrating as is will create a circular dependency Thus, we can integrate either by moving Lint into the vpcmodel or by separation of vpcmodel to distinct well defined packages with interfaces between them. The former solution is highly undesired, and thus we are left with the later one

(I did performs a few attempts of a quick and dirty separation of the vpcmodel that will enable the integration, and ended up with circular dependencies. Seems there are no short cuts here)

zivnevo commented 1 month ago

Related to #212