dev-base - Githubissues

nstrydom2 / anonfile-api

An unofficial Python Anonfiles.com API

MIT License

62 stars 24 forks source link

dev-base #56

Closed hentai-chan closed 3 years ago

hentai-chan commented 3 years ago

Creates a new development branch for the next release. I noticed that the authenticated decorator became redundant as soon as we discovered that passing tokens to ctor is optional anyway. This change doesn't warrant a new release yet, so I'll this branch up open as a base for the next version.

hentai-chan commented 3 years ago

I also added the following changes that I made recently to the RequestHandler class in hentai:

use a session context manager to ensure that sessions are properly closed (which is important to avoid leaving sockets open; this can trigger a ResourceWarning in some instances)
this also ensures that the connection is released back to the pool to increase efficiency
in the page download method, write the chunk in size of 1MiB, i.e. 1024*1024 bytes in iter_content

hentai-chan commented 3 years ago

@nstrydom2 this PR is ready for review

hentai-chan commented 3 years ago

I noticed a few finishing touches I'd like to make before you review this PR, so please bear with me a little longer ^^` Working on a different code base now, but I'll get to it afterwards~

hentai-chan commented 3 years ago

Feeling ready now! :)

hentai-chan commented 3 years ago

Third time's a charm, now also implemented the batch file option.