ntedgi / node-efficientnet

tensorflowJS implementation of EfficientNet 🚀
https://www.npmjs.com/package/node-efficientnet
MIT License
257 stars 37 forks source link

feature / support `i18n` #32

Closed luoye-fe closed 3 years ago

ntedgi commented 3 years ago

Its ok after we merge your code we publish a major release ‘2.0.0’

On Sat, 27 Mar 2021 at 17:13 luoye @.***> wrote:

@.**** commented on this pull request.

In src/EfficientnetModel.ts https://github.com/ntedgi/node-efficientnet/pull/32#discussion_r602724155 :

}

async inference(

  • imgPath: string | Buffer,
  • options: EfficientNetModelInferenceOptions
  • ): Promise;
  • async inference(
  • options: string | Buffer,
  • topK?: number
  • ): Promise;
  • async inference(

I mean, if someone use node-efficientnet such as mode.inference(img, 5), we make second param to be EfficientNetModelInferenceOptions , previous code will report an error

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/ntedgi/node-efficientnet/pull/32#discussion_r602724155, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHOL4EL6VCW3Q65YO4NZOFLTFXRZJANCNFSM4Z4SDNYQ .

luoye-fe commented 3 years ago

Its ok after we merge your code we publish a major release ‘2.0.0’ … On Sat, 27 Mar 2021 at 17:13 luoye @.> wrote: @*.** commented on this pull request. ------------------------------ In src/EfficientnetModel.ts <#32 (comment)> : > } async inference( - imgPath: string | Buffer, + options: EfficientNetModelInferenceOptions + ): Promise; + async inference( + options: string | Buffer, + topK?: number + ): Promise; + async inference( I mean, if someone use node-efficientnet such as mode.inference(img, 5), we make second param to be EfficientNetModelInferenceOptions , previous code will report an error — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#32 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHOL4EL6VCW3Q65YO4NZOFLTFXRZJANCNFSM4Z4SDNYQ .

ok, has modified