Closed kiegel closed 9 years ago
The treatment of music keys doesn't seem consistent.
240 10 |a Concertos, |m horn, orchestra, |n K. 417, |r E♭ major; |o arranged 384 0_ |a E♭ major
gives:
bf:musicKey "E♭ major",
"E♭ major;" ;
(OCLC # 49569102)
but
240 10 |a Sonatas, |m violin, piano, |n no. 1, op. 13, |r A major 384 0_ |a A major
gives
bf:musicKey "A major" ;
(OCLC # 807032670)
Why are there two keys from one record but only one from another? Do you de-duplicate?
Also, it would be useful to know whether the key indicated is the original key or a transposed one, which is given by the first indicator.
I think this is a product of whatever you're using to go from rdfxml . There are two musicKeys : in your second record: http://bibframe.org/resources/HST1418659702/bibframe.rdf There is no deduping between 240$r and 384$a. I'll see about adding "transposed" based on the indicator1. Note that wouldn't do anything to the 240$r musicKey.
bf:musicKey seems to pick up only one key, or music keys from only certain fields.
For example:
100 1_ |a Beethoven, Ludwig van, |d 1770-1827. 240 10 |a Sonatas, |m piano, |n no. 8, op. 13, |r C minor ... 700 12 |a Beethoven, Ludwig van, |d 1770-1827. |t Sonatas, |m piano, |n no. 14, op. 27, no. 2, |r C♯ minor. 700 12 |a Beethoven, Ludwig van, |d 1770-1827. |t Sonatas, |m piano, |n no. 23, op. 57, |r F minor.
gives:
bf:musicKey "C minor" ;
missing C♯ minor and F minor.
Of course, in works that are compilations, it is not clear that the following is useful:
since it lacks a linkage between the keys and the parts they are associated with.
(OCLC # 09424887)