ntra00 / marc2bibframe

Convert marc to BIBFRAME 1.0 - see lcnetdev/marc2bibframe2 for current release
http://www.loc.gov/bibframe/
Other
64 stars 20 forks source link

Saxon error on master branch #243

Closed rjyounes closed 9 years ago

rjyounes commented 9 years ago

With the latest code from the master, I get the following error:

Error on line 72 of saxon.xqy: XPDY0002: No value supplied for required parameter $usebnodes

The error is not generated on the dewey branch. If the master is not intended to be stable, please let me know and I will continue to use dewey.

<?xml version='1.0' encoding='UTF-8'?><collection xmlns='http://www.loc.gov/MARC21/slim'>
<record>
  <leader>01033cam a22002891  4500</leader>
  <controlfield tag="001">102063</controlfield>
  <controlfield tag="005">20141019191704.0</controlfield>
  <controlfield tag="008">860506s1957    nyua     b    000 0 eng  </controlfield>
  <datafield ind1=" " ind2=" " tag="010">
    <subfield code="a">   56010158/L </subfield>
  </datafield>
  <datafield ind1=" " ind2=" " tag="035">
    <subfield code="a">(CStRLIN)NYCX86B63464</subfield>
  </datafield>
  <datafield ind1=" " ind2=" " tag="035">
    <subfield code="a">(NIC)notisAAL3258</subfield>
  </datafield>
  <datafield ind1=" " ind2=" " tag="035">
    <subfield code="a">(OCoLC)1345399</subfield>
  </datafield>
  <datafield ind1=" " ind2=" " tag="035">
    <subfield code="a">102063</subfield>
  </datafield>
  <datafield ind1=" " ind2=" " tag="040">
    <subfield code="c">NIC</subfield>
    <subfield code="d">NIC</subfield>
  </datafield>
  <datafield ind1="0" ind2=" " tag="050">
    <subfield code="a">RC941</subfield>
    <subfield code="b">.C6</subfield>
  </datafield>
  <datafield ind1=" " ind2=" " tag="082">
    <subfield code="a">616.2</subfield>
  </datafield>
  <datafield ind1="0" ind2="0" tag="245">
    <subfield code="a">Clinical cardiopulmonary physiology.</subfield>
    <subfield code="c">Sponsored by the American College of Chest Physicians.  Editorial board: Burgess L. Gordon, chairman, editor-in-chief, Albert H. Andrews [and others]</subfield>
  </datafield>
  <datafield ind1=" " ind2=" " tag="260">
    <subfield code="a">New York,</subfield>
    <subfield code="b">Grune &amp; Stratton,</subfield>
    <subfield code="c">1957.</subfield>
  </datafield>
  <datafield ind1=" " ind2=" " tag="300">
    <subfield code="a">759 p.</subfield>
    <subfield code="b">illus.</subfield>
    <subfield code="c">27 cm.</subfield>
  </datafield>
  <datafield ind1=" " ind2=" " tag="504">
    <subfield code="a">Includes bibliography.</subfield>
  </datafield>
  <datafield ind1=" " ind2="0" tag="650">
    <subfield code="a">Chest</subfield>
    <subfield code="x">Diseases</subfield>
  </datafield>
  <datafield ind1=" " ind2="7" tag="650">
    <subfield code="a">Chest</subfield>
    <subfield code="x">Diseases</subfield>
    <subfield code="2">fast</subfield>
    <subfield code="0">(OCoLC)fst00853831</subfield>
  </datafield>
  <datafield ind1="1" ind2=" " tag="700">
    <subfield code="a">Gordon, Burgess L.</subfield>
    <subfield code="q">(Burgess Lee),</subfield>
    <subfield code="d">1892-</subfield>
    <subfield code="e">ed.</subfield>
  </datafield>
  <datafield ind1="2" ind2=" " tag="710">
    <subfield code="a">American College of Chest Physicians.</subfield>
  </datafield>
  <datafield ind1=" " ind2=" " tag="905">
    <subfield code="a">19880603120000.0</subfield>
  </datafield>
  <datafield ind1="2" ind2=" " tag="948">
    <subfield code="a">20141019</subfield>
    <subfield code="b">m</subfield>
    <subfield code="d">batch</subfield>
    <subfield code="e">lts</subfield>
    <subfield code="x">addfast</subfield>
  </datafield>
  <datafield ind1=" " ind2=" " tag="950">
    <subfield code="l">VET</subfield>
    <subfield code="a">RB113</subfield>
    <subfield code="b">.C64</subfield>
    <subfield code="f">BASIC</subfield>
    <subfield code="i">05/06/86 N</subfield>
  </datafield>
</record>
</collection>
kirkhess commented 9 years ago

I'm working on adding CI support to this project and the command below is one of my unit tests. We will update the documentation to include the bnode parameter.

(And if you don't use maven just replace the .m2 path with the path to your saxonHE9.x jar file.)

java -cp ~/.m2/repository/net/sf/saxon/Saxon-HE/9.6.0-5/Saxon-HE-9.6.0-5.jar net.sf.saxon.Query xbin/saxon.xqy marcxmluri="http://lccn.loc.gov/61008194/marcxml" baseuri="http://bibframe.org/" serialization=rdf.xml usebnodes=true

kirkhess commented 9 years ago

I found out why this wasn't working - the namespace for saxon was incorrect. If you use a Saxon9HE jar < version 9.5.x it will work now.

Saxon 9.6.x appears to have removed support for defaults in favor of the XQuery 3.0 syntax & I will commit a saxon3.xqy which will support the newer syntax.

rjyounes commented 9 years ago

I'm looking for the most recent stable version to run bulk conversions with. It might be better to work off a branch rather than the master. Is dewey considered a stable version, or is there a more recent stable revision where you could cut a branch?

ntra00 commented 9 years ago

the master is the stable version. Dewey was last updated months ago.

kirkhess commented 9 years ago

Rebecca,

Those are good suggestions but unfortunately we're not doing full SCM with this project so for your purposes you should consider master 'stable' & report any other issues.

I'll do something with the dewey branch since I think it's kind of confusing and consider a release point in the near future so we can work from that point forward with development branches.

Let us know how your bulk tool is working - we might find it useful here too!

Thanks,

On Fri, May 29, 2015 at 4:34 PM, Rebecca Younes notifications@github.com wrote:

I'm looking for the most recent stable version to run bulk conversions with. It might be better to work off a branch rather than the master. Is dewey considered a stable version, or is there a more recent stable revision where you could cut a branch?

— Reply to this email directly or view it on GitHub https://github.com/lcnetdev/marc2bibframe/issues/243#issuecomment-106928153 .