Closed ndushay closed 8 years ago
I have been trying to reverse engineer some of the algorithms in use here, e.g. "when is an bf:Instance in the output."
In the course of this, I discovered a number of things, such as:
https://github.com/lcnetdev/marc2bibframe/blob/master/modules/module.MBIB-2-BIBFRAME-Shared.xqy#L1193
etc.
No one is perfect -- the question is ... should I be submitting pull requests for this sort of thing?
Yes, submit a pull request and we'll review it, thanks!
removed $edition-instances from processing
I have been trying to reverse engineer some of the algorithms in use here, e.g. "when is an bf:Instance in the output."
In the course of this, I discovered a number of things, such as:
https://github.com/lcnetdev/marc2bibframe/blob/master/modules/module.MBIB-2-BIBFRAME-Shared.xqy#L1193
etc.
No one is perfect -- the question is ... should I be submitting pull requests for this sort of thing?