search

nulab / scala-oauth2-provider

OAuth 2.0 server-side implementation written in Scala
MIT License
537 stars 97 forks source link

Consider using scalafmt #111

Closed rmmeans closed 7 years ago

rmmeans commented 7 years ago

I'd be curious of your thoughts of adding scalafmt (https://olafurpg.github.io/scalafmt/) to this library? It would make it easier to contribute to as code formatting would be consistently applied and even have tests fail if a contribution comes in that is not formatted to the scalafmt settings.

If you consider it, I might suggest these format settings in the .scalafmt.conf file:

style = defaultWithAlign
maxColumn = 120
tsuyoshizawa commented 7 years ago

I know scalafmt and already using it on my private project.

However, we already use scalariform. https://github.com/nulab/scala-oauth2-provider/blob/master/project/plugins.sbt

I'm not sure changing library is worth now.

rmmeans commented 7 years ago

I didn't even catch that scalariform was in the library. I guess I'm just used to what seems to be the more opinionated scalafmt. Thanks