search

numixproject / numix-icon-theme

Official base icon theme from the Numix project.
http://numixproject.github.io
GNU General Public License v3.0
779 stars 87 forks source link

Missing kde icons from base #580

Open andia89 opened 9 years ago

andia89 commented 9 years ago

Ok apart from Adwaita, Elementary and gnome oxygen also misses a lot of base icons (thankfully a lot of symlinks are possible in this one). Be warned the list is extremely long :)

EDIT: Since breeze is the new default icon theme I'm adding here also the icons in the breeze theme that are not covered in other issues so far...

Foggalong commented 9 years ago

@wa4557 @dirtydancing @palob It might be good to only work on one of these lists at a time, especially considering there could be significant overlap between them. Not suggesting we close this one just that we focus on completing the elementary one first.

One another note, this is pretty good proof of how shit our KDE support is.

andia89 commented 9 years ago

As far as I can see there is unfotunately very little overlapp between those lists :( But yeah since elementary was the first issue it should be fixed first. Just waiting for @bil-elmoussaoui to fix the list in #437 (a lot of wrong icons there)...

bilelmoussaoui commented 9 years ago

I'm going to do that in 10 days. I still have to pass one last exam

Le 17 juin 2015 à 09:46, wa4557 notifications@github.com a écrit :

As far as I can see there is unfotunately very little overlapp between those lists :( But yeah since elementary was the first issue it should be fixed first. Just waiting for @bil-elmoussaoui to fix the list in #437 (a lot of wrong icons there)...

— Reply to this email directly or view it on GitHub.

dirtydancing commented 9 years ago

@bil-elmoussaoui Good luck!

Continuing the conversation from https://github.com/numixproject/numix-icon-theme/issues/437#issuecomment-111479399: While I appreciate the lists, I would like to point out that even adding every icon on the lists will not solve every specific issue.

Take e.g. bluetooth-active-symbolic.svg in elementary OS Freya, cf. https://github.com/numixproject/numix-icon-theme/issues/464: This is not on the elementary list, as this already exists in Numix base. But, it exists in the scalable directory only, and for elementary OS Freya consistency it would need to be in the fixed size directories. This might be a special case, but I figure it is good to be aware of this "limitation" of the lists.

I have also already noted that icons are missing from the Adwaita list over at https://github.com/numixproject/numix-icon-theme/issues/577. I will address that over there.

palob commented 9 years ago

@wa4557 Is this Oxygen only? Maybe there are even some additional for the new Plasma 5 theme Breeze.

andia89 commented 9 years ago

@palob As far as I can see the icons from breeze are a sublist of this list (more or less). So if all icons from this issue are fixed, there won't be a lot of breeze icons left to be fixed...

Foggalong commented 9 years ago

I'd agree. Definitely leave doing Breeze until we've done Oxygen, the overlap will be enormous.

hlechner commented 9 years ago

text/x-po is for the same mimetype as text/x-gettext-translation

563

hlechner commented 9 years ago

text-rtf: rtf = rich text format = (text-richtext.svg -> application-document.svg):

hlechner commented 9 years ago

application-x-srt and application-x-srtrip are actually (.srt) files, so:

palob commented 9 years ago

For text-rtf.svg there's already application-rtf.svg to symlink to.

hlechner commented 9 years ago

You're right, but why the text-richtext.svg send to application-document.svg instead of application-rtf.svg?

palob commented 9 years ago

Ah, OK. I thought there wasn't such symlink because it's on the list above. Yeah, should be fixed.

palob commented 9 years ago

According to wikipedia text/richtext isn't the same.

hlechner commented 9 years ago

I didn't know about the older rich text, which confused me, thanks for the explanation.

palob commented 9 years ago

dialog-ok-apply action icon is already present.

palob commented 9 years ago

Anybody's got a clue what this section in the index.theme of gnome and Adwaita (which haven't got an inheritance line) is all about? Does it add any good?

# KDE Specific Stuff
DisplayDepth=32
LinkOverlay=link_overlay
LockOverlay=lock_overlay
ZipOverlay=zip_overlay
DesktopDefault=48
DesktopSizes=16,22,32,48,64,72,96,128
ToolbarDefault=22
ToolbarSizes=16,22,32,48
MainToolbarDefault=22
MainToolbarSizes=16,22,32,48
SmallDefault=16
SmallSizes=16
PanelDefault=32
PanelSizes=16,22,32,48,64,72,96,128
Foggalong commented 9 years ago

I have no idea. CC: @PaoloRotolo @me4oslav @satya164 @cldx

satya164 commented 9 years ago

I've no idea either, but this looks like some configuration about the sizes of icons to be displayed.

bilelmoussaoui commented 9 years ago

@wa4557 @Foggalong you forgot to tick the weather indicator icons ;)

palob commented 9 years ago

I've started work on the edit-table-... action icons. How about those drafts? edit-table

andia89 commented 9 years ago

Great as always :+1:

dirtydancing commented 9 years ago

Agreed, this is great! :+1:

As to edit-table-cell-split: Maybe just have a blue line without an arrow pointing to the bottom? Currently, this might be confused with a row being "collapsed" vertically, whereas in this case this is supposed to mean to split the table cell horizontally. EDIT: argh, of course the other way around: this is supposed to symbolise a vertical split :-)

andia89 commented 9 years ago

Or a vertical line with two horizontal arrows pointing away from that line?

bilelmoussaoui commented 9 years ago

Those icons might be used to create a Libreoffice Numix theme ;)

palob commented 9 years ago

Two alts for the cell split icon:

split-alt

dirtydancing commented 9 years ago

Not sure about either of those. Among the three variants so far, I then actually like the first one the best. Maybe have two "separated" parts, to symbolise a "split"?

palob commented 9 years ago

On another note: The icons from my latest PRs haven't been ticked off.

andia89 commented 9 years ago

I guess the arrows should point towards the edges to symbolize splitting? i'll tick the icons asap

palob commented 9 years ago

Even more alts: edit-table-alt2

andia89 commented 9 years ago

4 is awesome

andia89 commented 9 years ago

Altough: it kind of looks like an elevator. I vote for 5 which is even more awesome :)

dirtydancing commented 9 years ago

I prefer 3 :-) Sweet detail that the blue line in 3 extends a little further :+1: I am not sure if any arrows hit the target, because arrows imply moving s.th. But imo "split" does not mean move.

palob commented 9 years ago

One last alternative: edit-table6

dirtydancing commented 9 years ago

Wow, you actually improved on 3 with this one, amazing, this is such a tricky icon to do. I vote for 6 :+1:

andia89 commented 9 years ago

Yes i agree variant 6 is the best

Foggalong commented 9 years ago

var 6 best 6

palob commented 9 years ago

Breeze is now a superset of Oxygen.

andia89 commented 9 years ago

Ok, should I update the list? (4760 icons that's quite a task)

palob commented 9 years ago

I'd say yes. Maybe there are more icons which can be done by symlinks.

andia89 commented 9 years ago

Do you know where to find a recent version? The version from the ubuntu repo seems outdated since there are a lot of icons missing that are present in oxygen

palob commented 9 years ago

I don't think there's a release tagged yet, it will be published with Plasma 5.5 5.4.2.

This or this is the git repo.

Btw, while I was at it I've found something which might be of help if we decide to provide LibreOffice action icons.

andia89 commented 9 years ago

Ok I'll add the missing icons as soon as 5.5 is released.

I guess if we finish all those lists we get a libreoffice Icon theme for free :)

palob commented 9 years ago

Breeze 5.4.2 is out: https://launchpad.net/ubuntu/+source/breeze/4:5.4.2-0ubuntu2

palob commented 9 years ago

Drafts for the Tcl mimetype

tcl-all

andia89 commented 9 years ago

I love the second one

Foggalong commented 9 years ago

:+1:

palob commented 9 years ago

I know something like this was discussed before: is there any downside to adding breeze (must be lowercase) to the inheritance line.

Right now oxygen is the fallback theme for icons not present in Numix. However oxygen doesn't mix that well with Numix and leaves blank spots for icons that have been added to breeze.

palob commented 9 years ago

The knotes-* icons can be ticked off (#838).

andia89 commented 9 years ago

no they cannot because the icons above are not knotes- but rather knotes_