search

numo-labs / lambda-taggable-createDocument

:memo: Tag-E Create and Update Documents
3 stars 0 forks source link

V2 saves tags to S3 #14

Closed nelsonic closed 8 years ago

nelsonic commented 8 years ago

Ready.

This pull request updates the lambda-taggable-createDocument to insert tag documents into S3 as requested by @plaenen for the Neo4J-based tagging system "Tag-E V2". Updated all tests and docs to that effect.

@nikhilaravi please review. Thanks!

nikhilaravi commented 8 years ago

@nelsonic looks good! Will merge after codeship is done with checks! Just wondering, should we start using 'callback(err, res)' instead of context.succeed and fail as I was reading that context is now deprecated for node 4.3.2 in lambda?

nelsonic commented 8 years ago

@nikhilaravi yes callback is the way to go. 👍 http://docs.aws.amazon.com/lambda/latest/dg/nodejs-prog-model-handler.html#nodejs-prog-model-handler-callback