nutofem / nuto

NuTo - yet another finite element library
https://nuto.readthedocs.io
Boost Software License 1.0
17 stars 5 forks source link

Pde mesh move problem #128

Closed TTitscher closed 7 years ago

TTitscher commented 7 years ago

ValueVector.h:

//! @brief container that stores values of T and keeps references to these values valid
//! @remark Normally, it is a no-brainer to use boost::ptr_vector here. It provides all
//! the nice value semantics for free. However, there is an issue regarding move.
//!         https://stackoverflow.com/questions/44130076/moving-a-boostptr-vector
//! Therefore, here is a custom implementation with only the basic features.

We want our mesh to be movable. boost::ptr_vector does not behave as expected and is replaced.

codecov[bot] commented 7 years ago

Codecov Report

Merging #128 into PDE_reviewed will increase coverage by 0.14%. The diff coverage is 97.46%.

Impacted file tree graph

@@               Coverage Diff                @@
##           PDE_reviewed     #128      +/-   ##
================================================
+ Coverage         59.09%   59.23%   +0.14%     
================================================
  Files               282      282              
  Lines             11394    11440      +46     
================================================
+ Hits               6733     6777      +44     
- Misses             4661     4663       +2
Impacted Files Coverage Δ
test/base/ValueVector.cpp 100% <100%> (ø) :arrow_up:
src/mechanics/mesh/MeshFemDofConvert.cpp 97.33% <100%> (ø) :arrow_up:
src/base/ValueVector.h 100% <100%> (ø) :arrow_up:
src/mechanics/mesh/UnitMeshFem.cpp 100% <100%> (ø) :arrow_up:
src/mechanics/mesh/MeshFem.h 100% <100%> (ø) :arrow_up:
src/mechanics/elements/ElementFem.h 95.55% <100%> (ø) :arrow_up:
test/mechanics/mesh/UnitMeshFem.cpp 100% <100%> (ø) :arrow_up:
test/mechanics/mesh/MeshFem.cpp 97.4% <84.61%> (-2.6%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4c245b...7947731. Read the comment docs.