nutofem / nuto

NuTo - yet another finite element library
https://nuto.readthedocs.io
Boost Software License 1.0
17 stars 5 forks source link

Add quadratic line element #173

Closed TTitscher closed 6 years ago

TTitscher commented 6 years ago

Gmsh node numbering does not always match our numbering, e.g. for quadratic line elements. This changes in the gmsh import allows addressing this.

codecov[bot] commented 6 years ago

Codecov Report

Merging #173 into PDE_reviewed will increase coverage by 0.09%. The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff                @@
##           PDE_reviewed     #173      +/-   ##
================================================
+ Coverage         80.96%   81.06%   +0.09%     
================================================
  Files               225      225              
  Lines              7276     7297      +21     
================================================
+ Hits               5891     5915      +24     
+ Misses             1385     1382       -3
Impacted Files Coverage Δ
test/mechanics/mesh/MeshGmsh.cpp 100% <100%> (ø) :arrow_up:
src/mechanics/mesh/MeshGmsh.cpp 96.88% <100%> (+0.57%) :arrow_up:
...echanics/interpolation/InterpolationTrussLobatto.h 100% <0%> (+8.69%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e182acf...8ac6a8a. Read the comment docs.

Psirus commented 6 years ago

I'd wait for other interpolations, maybe it happens more often, and it makes sense to introduce a mapping of vector<int> to vector<int> or something that handles it. So that I could say GetGmshToNuToMapping(GmshElementType) or similar.

TTitscher commented 6 years ago

IMO we should handle the whole det(jacobian) thing in a dedicated PR.