Psirus commented 6 years ago

Copied from last time:

This will add two additional jobs to our Travis build that fail when there are any compiler warnings. These have been missed previously, because one usually doesn't test on multiple compilers on ones own machine.

Note:

These "Compiler warnings" jobs are allowed to fail; even if there is a warning, you'll still get the green tick.
They fail on the first warning, even if there are more, to reduce Travis time. The corresponding "Normal build" will have all the warnings.

codecov[bot] commented 6 years ago

Codecov Report

Merging #212 into PDE_reviewed will not change coverage. The diff coverage is n/a.

@@              Coverage Diff              @@
##           PDE_reviewed     #212   +/-   ##
=============================================
  Coverage         67.82%   67.82%           
=============================================
  Files               312      312           
  Lines             12089    12089           
=============================================
  Hits               8199     8199           
  Misses             3890     3890

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90c1fa5...43b7a59. Read the comment docs.

Psirus commented 6 years ago

Yeah, you're right. Currently, that takes about 2 seconds, but you're right, this will probably become relevant in the future.

nutofem / nuto

Reactivate warnings checks on Travis #212

Codecov Report