search

nutofem / nuto

NuTo - yet another finite element library
https://nuto.readthedocs.io
Boost Software License 1.0
17 stars 5 forks source link

Pde prism create #220

Closed TTitscher closed 6 years ago

TTitscher commented 6 years ago

The goal is to take the triangle between two tetrahedron elements and blow it up to 3d prism. For concrete geometry, this can be used to introduce an interfacial transition zone between matrix and aggregates.

I planned to rewrite OldNuTo::ElementPrismCreate(), which is a quite buggy, long and incomprehensive function. After receiving a tremendously helpful code snippet of @pmueller2 (thanks!!), I decided to do that directly in gmsh. As the gmsh code is quite complex and cannot make use of the openCascade features of gmsh3, I added the GmshWriter to wrap everything.

The tests consist of running gmsh on the generated .geo files and read them with MeshGmsh without errors. Do you think that is enough?

codecov[bot] commented 6 years ago

Codecov Report

Merging #220 into PDE_reviewed will increase coverage by 1.98%. The diff coverage is 97.01%.

Impacted file tree graph

@@               Coverage Diff                @@
##           PDE_reviewed     #220      +/-   ##
================================================
+ Coverage         81.91%   83.89%   +1.98%     
================================================
  Files               284      291       +7     
  Lines             10393    10380      -13     
================================================
+ Hits               8513     8708     +195     
+ Misses             1880     1672     -208
Flag Coverage Δ
#integrationtests 60.47% <90.52%> (+0.34%) :arrow_up:
#unittests 81.75% <69.04%> (+2.16%) :arrow_up:
Impacted Files Coverage Δ
...c/mechanics/integrationtypes/IntegrationTypeBase.h 100% <ø> (ø) :arrow_up:
...mechanics/interpolation/InterpolationCompanion.cpp 20.37% <0%> (-0.79%) :arrow_down:
.../interpolation/InterpolationTetrahedronQuadratic.h 100% <100%> (ø)
...s/integrationtests/geometryConcrete/GmshWriter.cpp 100% <100%> (ø)
...hanics/interpolation/InterpolationPrismQuadratic.h 100% <100%> (ø)
src/geometryConcrete/GmshWriter.h 100% <100%> (ø)
...nics/interpolation/InterpolationPrismQuadratic.cpp 100% <100%> (ø)
...nterpolation/InterpolationTetrahedronQuadratic.cpp 100% <100%> (ø)
src/geometryConcrete/GmshWriter.cpp 100% <100%> (ø)
src/mechanics/mesh/MeshGmsh.cpp 96.91% <66.66%> (+0.02%) :arrow_up:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 570ace9...9fd3361. Read the comment docs.