nutofem / nuto

NuTo - yet another finite element library
https://nuto.readthedocs.io
Boost Software License 1.0
17 stars 5 forks source link

Rename src/ to nuto/ #222

Closed Psirus closed 6 years ago

Psirus commented 6 years ago

As discussed in the meeting, this will rename src/ to nuto/, and the includes change from #include "base/Whatever.h" to #include "nuto/base/Whatever.h".

codecov[bot] commented 6 years ago

Codecov Report

Merging #222 into PDE_reviewed will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           PDE_reviewed     #222   +/-   ##
=============================================
  Coverage         83.89%   83.89%           
=============================================
  Files               291      291           
  Lines             10380    10380           
=============================================
  Hits               8708     8708           
  Misses             1672     1672
Flag Coverage Δ
#integrationtests 60.47% <ø> (ø) :arrow_up:
#unittests 81.75% <ø> (ø) :arrow_up:
Impacted Files Coverage Δ
nuto/visualize/AverageHandler.cpp 89.74% <ø> (ø)
nuto/mechanics/elements/ElementInterface.h 100% <ø> (ø)
...o/mechanics/integrationtypes/IntegrationTypeBase.h 100% <ø> (ø)
nuto/visualize/Cell.cpp 83.33% <ø> (ø)
nuto/mechanics/constitutive/EngineeringStress.h 100% <ø> (ø)
nuto/visualize/Cell.h 100% <ø> (ø)
nuto/math/EigenSparseSolve.h 100% <ø> (ø)
...uto/mechanics/integrationtypes/IntegrationType3D.h 0% <ø> (ø)
...ics/integrationtypes/IntegrationType0DBoundary.cpp 0% <ø> (ø)
nuto/mechanics/elements/SpectralShapeFunctions.cpp 99.16% <ø> (ø)
... and 206 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0da8609...25479ea. Read the comment docs.

Psirus commented 6 years ago

For same directory, I'd just use the #include "Stuff.h". For everything else, I think #include "nuto/math/stuff/Stuff.h" is fine. Personally, I don't like #include ../stuff2/OtherStuff.h", but in the end, not important.

As for when to change: when you're writing new code or touching it anyway and it bothers you. No need to go over everything to "fix" it, imho.