nutofem / nuto

NuTo - yet another finite element library
https://nuto.readthedocs.io
Boost Software License 1.0
17 stars 5 forks source link

Extend Mesh #227

Open pmueller2 opened 6 years ago

pmueller2 commented 6 years ago

If you import a mesh from Gmsh you get a MeshGmsh object that saves beside a mesh also some Groups of ElementCollections (corresponding to Gmsh physical groups). I really like that feature and I think this is not related to Gmsh but should belong to our or an extended mesh class.

What do you think?

TTitscher commented 6 years ago

I like the idea of the extended mesh. But I am not sure, if that should be another class or not. I always like the separation. On the one hand, the user can choose his includes. E.g. UnitMesh? #include <.../UnitMeshFem.h> Gmsh? #include <.../MeshGmsh.h> And maybe now: #include <.../MeshFemCompanion.h>? :smile: On the user hand, the user has to know that something like that exists beside the mesh.

Features could include:

vhirtham commented 6 years ago

Maybe even perform NodeMerge/Extract

Yes please. A function that spits out a Eigen::MatrixXd containing the correctly ordered dof values would be really nice and saves the "user" 2 additional conversion steps: