codecov[bot]
commented
6 years ago Codecov Report
Merging #242 into PDE_reviewed will decrease coverage by
0.08%. The diff coverage is93.33%.
@@ Coverage Diff @@
## PDE_reviewed #242 +/- ##
================================================
- Coverage 84.42% 84.34% -0.09%
================================================
Files 294 294
Lines 10774 10773 -1
================================================
- Hits 9096 9086 -10
- Misses 1678 1687 +9| Flag | Coverage Δ | |
|---|---|---|
| #integrationtests | 62.06% <79.31%> (-0.15%) |
:arrow_down: |
| #unittests | 87.58% <93.22%> (-0.14%) |
:arrow_down: |
| Impacted Files | Coverage Δ | |
|---|---|---|
| nuto/mechanics/tools/QuasistaticSolver.h | 100% <ø> (ø) |
:arrow_up: |
| nuto/mechanics/constraints/Constraints.h | 100% <ø> (ø) |
:arrow_up: |
| nuto/mechanics/constraints/Equation.h | 100% <100%> (ø) |
:arrow_up: |
| test/mechanics/dofs/DofNumbering.cpp | 96.96% <100%> (-0.09%) |
:arrow_down: |
| nuto/mechanics/constraints/ConstraintCompanion.cpp | 100% <100%> (ø) |
:arrow_up: |
| ...ntegrationtests/mechanics/QuasistaticProblem1D.cpp | 100% <100%> (ø) |
:arrow_up: |
| test/mechanics/constraints/Constraints.cpp | 98.7% <100%> (+0.05%) |
:arrow_up: |
| nuto/mechanics/dofs/DofNumbering.cpp | 75.75% <66.66%> (-24.25%) |
:arrow_down: |
| nuto/mechanics/constraints/Constraints.cpp | 93.25% <92.3%> (-0.15%) |
:arrow_down: |
| test/mechanics/constraints/ConstraintCompanion.cpp | 94.3% <95.23%> (-0.65%) |
:arrow_down: |
| ... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 3a6f26b...3bcf001. Read the comment docs.
In the already merged removeJK branch, there was still the renumbering based on the constraints included. This is no longer required, and was now removed here. While implementing this, I realized that in almost all cases, when we loop over the constraint equations, we either need the dependent term or the independent terms, never both. Also, every equation should have one single dependent term. As a consequence, I have split the terms in equation into the dependent term that is always set in the constructor, and the (now called independent) terms that are the other terms. That requires some changes, i.e. constraintEquation.AddTerm has to be replaced by constraintEquation.AddIndependentTerm. I could have also not renamed this, however I thought this would be clearer for people who used this functionality and with the renaming are aware that the first term in this list is no longer the dependent term.