Closed pmueller2 closed 6 years ago
Merging #245 into PDE_reviewed will increase coverage by
0.03%
. The diff coverage is95.12%
.
@@ Coverage Diff @@
## PDE_reviewed #245 +/- ##
================================================
+ Coverage 84.54% 84.57% +0.03%
================================================
Files 299 299
Lines 11000 11018 +18
================================================
+ Hits 9300 9319 +19
+ Misses 1700 1699 -1
Flag | Coverage Δ | |
---|---|---|
#integrationtests | 62.12% <91.66%> (+0.1%) |
:arrow_up: |
#unittests | 87.85% <95.12%> (+0.04%) |
:arrow_up: |
Impacted Files | Coverage Δ | |
---|---|---|
nuto/mechanics/constraints/Constraints.h | 100% <100%> (ø) |
:arrow_up: |
test/mechanics/constraints/Constraints.cpp | 98.7% <100%> (ø) |
:arrow_up: |
nuto/mechanics/constraints/Constraints.cpp | 95.09% <93.54%> (+1.83%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 09696ea...2b91e4b. Read the comment docs.
Fixes a bug when building the constraint matrix.
A prerequisite when doing this constraints stuff is a numbering that is a permutation of 0,...,numDofs or in other words: it is a dense/continuous numbering starting with 0. The constraint matrix is rectangular with as much rows as dofs and as much columns as there are independent dofs. When referring to the rows of the constraint matrix one uses the original numbering but for the columns the numbering of the independent dofs is needed (with the dependent ones removed but continuous, starting at 0). There is now a method that returns this ordered numbering that is used by the BuildConstraintMatrix routine.
The actual bugfix is indicated with a comment.