search

nutofem / nuto

NuTo - yet another finite element library
https://nuto.readthedocs.io
Boost Software License 1.0
17 stars 5 forks source link

Add determinant check to Gmsh import. #260

Closed pmueller2 closed 6 years ago

pmueller2 commented 6 years ago

Throws if det(J) <= 0.

codecov[bot] commented 6 years ago

Codecov Report

Merging #260 into develop will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #260      +/-   ##
===========================================
+ Coverage    90.86%   90.86%   +<.01%     
===========================================
  Files          326      326              
  Lines        10898    10906       +8     
===========================================
+ Hits          9902     9910       +8     
  Misses         996      996
Flag Coverage Δ
#integrationtests 66.45% <88.88%> (+1.98%) :arrow_up:
#unittests 96.24% <100%> (ø) :arrow_up:
Impacted Files Coverage Δ
nuto/mechanics/mesh/MeshGmsh.cpp 97.14% <100%> (+0.07%) :arrow_up:
nuto/geometryConcrete/GmshWriter.cpp 100% <100%> (ø) :arrow_up:
test/mechanics/mesh/MeshGmsh.cpp 100% <100%> (ø) :arrow_up:
...s/integrationtests/geometryConcrete/GmshWriter.cpp 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ca44965...4dba699. Read the comment docs.

pmueller2 commented 6 years ago

The 3D GmshWriter tests fail due to distorted 2nd order elements generated by gmsh that have negative jacobians. I need help with this. Maybe someone has experience in fixing these kind of meshing errors?