nuts-foundation / nuts-event-octopus

Nuts service space engine for making sure events are caught and relayed.

GNU General Public License v3.0

0 stars 0 forks source link

Update event diagram with 'closed' event #35

Closed woutslakhorst closed 4 years ago

woutslakhorst commented 4 years ago

the closed event is the result from a nack at the other side.

Nuts consent request flow

codecov[bot] commented 4 years ago

Codecov Report

Merging #35 into master will not change coverage. The diff coverage is n/a.

Impacted Files	Coverage Δ
pkg/types.go	`100.00% <ø> (ø)`

stevenvegt commented 4 years ago

We've got 'nacked', 'cancelled', 'errored', 'closed' and we talked about 'denied'. This might get a little confusing for the newcommer. Any chance to reduce this set a bit or perhaps clear up the terminlogogy?

woutslakhorst commented 4 years ago

nacked == cancelled == closed Only:

nacked = action cancelled = event closed = state

So it would be better to chose 1. Let's do close for event/state. The user facing action/API can still be ack or nack.

woutslakhorst commented 4 years ago

I removed all the 'cancelled' references.

A nack leads to a close action which leads to a closed event at all the nodes.