update test gh workflow - Githubissues

nvuillam / vscode-groovy-lint

VSCode extension to lint , correct and format groovy and Jenkinsfile

https://nvuillam.github.io/vscode-groovy-lint/

MIT License

69 stars 18 forks source link

update test gh workflow #184

Closed djukxe closed 11 months ago

djukxe commented 1 year ago

Fixes # This PR is to improve/fix test gh workflow

Tests are still failing (2 passing, 13 failing) in the end though but I think it would require separate PR/rework as @stevenh suggested

Proposed Changes

Fix test on windows runner. vscode-test module is old and is trying to pull an win32 version of vscode which is not distributed anymore
remove dependency to xvfb-action gh action as xfvb is now part of ubuntu runner image
add testing on mac

Readiness Checklist

Author/Contributor

[ ] Add entry to the CHANGELOG.md listing the change and linking to the corresponding issue (if appropriate)
[ ] If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

[ ] Label as breaking if this is a large fundamental change
[ ] Label as either automation, bug, documentation, enhancement, infrastructure, or performance

stevenh commented 1 year ago

Thanks for the PR @djukxe there's already a big test refactor in development, so lets hold off on this until that's in.

If there are any additional changes needed after that we'll look again.

djukxe commented 1 year ago

Understood 👍