search

nvuillam / vscode-groovy-lint

VSCode extension to lint , correct and format groovy and Jenkinsfile
https://nvuillam.github.io/vscode-groovy-lint/
MIT License
68 stars 18 forks source link

Never option on tab warning isn't "sticky" #203

Open stretch327 opened 9 months ago

stretch327 commented 9 months ago

When you first open a groovy file and get the warning that says:

"CodeNarc linter doesn't like tabs, let's replace them by spaces ?"

The options that are available are "Always, Yes, No and Never"

If you select Never, it is treated as if you clicked "No" and you still have to answer this question again each time you open a new document.

stretch327 commented 8 months ago

Stale because you haven't looked at it?

nvuillam commented 8 months ago

@stretch327 indeed !

We are mostly 2 persons ( @stevenh and myself ) to maintain vscode-groovy-lint for free, and our available time is limited... sometimes it can take time :/

Maybe you'd like to help by submitting a pull request with a fix ?

stevenh commented 8 months ago

Never is currently acting as no for this session vs never ask me again, what's the intended behaviour here?

nvuillam commented 8 months ago

@stevenh "Never again for any Groovy file i'll open with this vscode" ^^

I don't know if it's good or not, but it was the previous behaviour so people are probably used to it ^^

stevenh commented 8 months ago

Thanks for the confirmation. I can confirm it's only set in a session variable there is no configuration option I could find for that, let me know if I missed something @nvuillam .

If the above is correct, to fix we would need to introduce a config option for this and have the dialog option interact with that and the document handler subscribe to config updates, so a little bit involved.

nvuillam commented 8 months ago

@stevenh let's check how it was done before your refactoring :) I think i wrote the option in vscode settings

stretch327 commented 7 months ago

Sounds like you guys have ideas how to fix it. Please keep this case open!