search

nytimes / Fech

Deprecated. Please see https://github.com/dwillis/Fech for a maintained fork.
http://nytimes.github.io/Fech/
Other
114 stars 30 forks source link

Summary mapping missing fields (0.5.0) #12

Closed capitolmuckrakr closed 12 years ago

capitolmuckrakr commented 12 years ago

Fields on Form 3P missing: -Col A Political Party Committees (Refunds of Contributions) -Col B Political Party Committees (Refunds of Contributions)

They're not that important -- Obama's 2008 post-general only lists $300 in them. We'll be forking in the next couple of weeks and will add them.

bycoffe commented 12 years ago

It looks like both those fields are there, but they use the same field names as the corresponding receipts field (17(b)), so the hash ends up losing it.

The col_a_political_party_committtees refunds field is at https://github.com/NYTimes/Fech/blob/master/sources/F3P.csv#L62 (the receipts field is at https://github.com/NYTimes/Fech/blob/master/sources/F3P.csv#L40) The col_b_political_party_committtees refunds field is at https://github.com/NYTimes/Fech/blob/master/sources/F3P.csv#L149 (the receipts field is at https://github.com/NYTimes/Fech/blob/master/sources/F3P.csv#L127)

capitolmuckrakr commented 12 years ago

When we fork, I'll rename the keys to col_a_political_party_committtees_refunds, col_b_political_party_committtees_refunds.

bycoffe commented 12 years ago

I've already made this change in our fork and submitted a pull request: https://github.com/NYTimes/Fech/pull/14

dwillis commented 12 years ago

Merged, thanks Aaron!