nzp-team / nzportable

Call of Duty: Zombies demake, powered by various Quake sourceports. https://docs.nzp.gay/
476 stars 47 forks source link

Settings never save #962

Closed coreybruce closed 3 days ago

coreybruce commented 3 weeks ago

Describe the bug When you change the settings like the resolution or other settings it will say Wrote $basedir/nzp/user_settings.cfg but once you restart everything is reset to the default setting. I have noticed this for a while and wanted to report this so it could be fixed, I just have the files in the .config folder.

Also I notice this message everytime I launch it in the terminal

./nzportable
Binary is located at "/home/corey/.config/NZP/"
couldn't exec config.cfg
couldn't exec nzportable.cfg
couldn't exec autoexec.cfg

To Reproduce Steps to reproduce the behavior:

  1. Open game
  2. change game settings
  3. restart game
  4. game runs with default settings

Expected behavior Saves settings

Screenshots/Footage Before: image After: image

Affected Platforms

State which platform(s) you've seen the bug occur.

Please also make note of any platforms you DID NOT test on.

Linux

MotoLegacy commented 3 days ago

I can't reproduce this ever since I massively rewrote our menu system. Can you give the latest builds a try and re-open if this still reproduces for you?

coreybruce commented 2 days ago

I tried the latest version but I have the same issue, I'll set the resolution and even my multiplayer name and when I close it the resolution in the settings will be reset even tho the config shows it

image

image

image

MotoLegacy commented 2 days ago

The resolution menu will always display the lowest supported at the start of the app, not the current/closest window resolution. Dumb bug I introduced myself :( I can't reproduce anything about the names or any other settings.

coreybruce commented 2 days ago

Ah I see that's a pain

So once you've set your name it stays? mine always resets to unknown solider

Before: image

After restart: image

MotoLegacy commented 2 days ago

You have to first click apply on another settings screen see (https://github.com/nzp-team/nzportable/issues/986), but yes it is dumped to user_settings.cfg once this is done and appears on a re-load

coreybruce commented 2 days ago

Also the reset issue has to been happening with my nzportable-bin package for a while and will reset the Windows to a small window after you set the resolution

Before image

After relaunch image

image

Maybe I might need to revise my launch/setup script :)

coreybruce commented 2 days ago

You have to first click apply on another settings screen see (#986), but yes it is dumped to user_settings.cfg once this is done and appears on a re-load

Which settings screen exactly?

MotoLegacy commented 2 days ago

Any. They all run saveconfig which will dump all of the cvars (including name) to user_settings.cfg