search

o19s / ubi

User Behavior Insights standard schema
Apache License 2.0
12 stars 4 forks source link

fix[event.schema.json]: query_id optional #20

Closed AnkitSiva closed 2 weeks ago

AnkitSiva commented 1 month ago

This is again a small, backwards-compatible change so I am not writing up the full RFC for this. The query_id field is required in the current schema. However, the scope of UBI is broader than only tracking the behavior of users after a search is performed. Indeed, the demo tracks user data before searches and writes an empty query ID to the index. This PR fixes that antipattern of a user writing an empty value to a required field.

Fixes this issue

jzonthemtn commented 1 month ago

Thanks @AnkitSiva!

epugh commented 4 weeks ago

I can see this argument... At this point in time, it's probably better for us to be laxer in our validation versus overly strict as we gain more "real world" use. So agreed.

epugh commented 2 weeks ago

as part of this, also making sure session_id is not required. we want to be careful about what we require...