oasisprotocol / explorer

Official explorer for the Oasis Network.
https://explorer.oasis.io
Apache License 2.0
8 stars 7 forks source link

Don't show TX error messages for empty error blocks #1444

Closed csillag closed 3 weeks ago

csillag commented 3 months ago

Some transactions have an error block like this:

"error": {
  "code": 0,
  "module": ""
}

An example found by @matevz is available here.

In these cases, no error message should be shown.

github-actions[bot] commented 3 months ago

Deployed to Cloudflare Pages

Latest commit: 89ba2cb5bb58d49ec613c0add4638cf5088729e3
Status:✅ Deploy successful!
Preview URL: https://befb585b.oasis-explorer.pages.dev
csillag commented 3 months ago

This is marked as draft until someone can verify that my interpretation of the situation is correct.

csillag commented 3 months ago

This is marked as draft until someone can verify that my interpretation of the situation is correct.

Yes: @kostko says that

Yes code 0 is always success.

So, we don't have to show an error message here.

lukaw3d commented 3 months ago

Frontend should not be fixing this

lubej commented 3 months ago

Frontend should not be fixing this

How about we create an issue upstream? And merge this quick fix for now. As it takes "ages" to propagate the change on the BE side to mainnet.

csillag commented 3 months ago

How about we create an issue upstream?

The discussion with the Nexus guys have been going on for 3 days now.

And merge this quick fix for now.

I agree, but waiting for @lukaw3d's decision.

As it takes "ages" to propagate the change on the BE side to mainnet.

Exactly.

lukaw3d commented 3 months ago

:shrug: seems very rare, and frontend can't correctly fix the transaction anyway: method missing, and status missing

csillag commented 2 months ago

Not much progress with the Nexus issue for the last 3 weeks. I still thing we ought to merge the frontend workaround, at least in order to remove the spurious error message...