search

oasisprotocol / explorer

Official explorer for the Oasis Network.
https://explorer.oasis.io
Apache License 2.0
8 stars 9 forks source link

[UX]: Oasis / ETH address switcher is unnecessary and confusing #1528

Closed CedarMist closed 3 weeks ago

CedarMist commented 2 months ago

IMPACT

URGENCY

PRODUCT ENVIRONMENT

Explorer

DESCRIPTION OF ISSUE

Ethereum addresses (0x...) are Ethereum addresses. Consensus addresses (oasis1...) are consensus addresses.

If you have an Ethereum address it doesn't mean there is any meaningful or practical way to use the oasis1 form of it, it will be confused with Consensus addresses which use a different signing scheme, which will lead to unrecoverable funds.

image

DEVICE / VIEWPORT

STEPS TO REPRODUCE

  1. Open https://explorer.oasis.io/testnet/sapphire/tx/d52b4a4f07c5287914ffb33401235d2fa962064f0d9bed2a3cd3ef813345f81b
  2. See the From/To fields of the transaction
  3. Toggle the Oasis/ETH widget to the right of 'Transactions'
  4. The addresses and transaction hash change

If I'm the owner of 0xaa264463D60802A260338339CEb385ef23417268, and I switch the toggle to Oasis mode, there and somebody sends funds to oasis1qrf6euzpnhrvu5u8a3y4428s7hgzvkchuca47v4k, there is no way for me to easily recover these funds - they can only be sent on Consensus etc.

Please can we be consistent with addresses.

ALTERNATIVES AND SUGGESTIONS

Don't provide this functionality. There should be no toggle for Oasis <-> ETH address formatting.

When the origin or destination is an Ethereum/Sapphire address, display it in 0x format. When the origin or destination is a Consensus address, display it in oasis1 format.

donouwens commented 2 months ago

Thanks for sharing this @CedarMist - was planning to work on this in the upcoming sprint so we will revisit this soon.