search

oceanprotocol-archive / oceandao-proposal-portal

OceanDao proposal portal
0 stars 1 forks source link

Feature/admin pages #29

Closed KatunaNorbert closed 2 years ago

KatunaNorbert commented 2 years ago

Add admin pages

idiom-bytes commented 2 years ago

Hi, I have reviewed this PR and modified a few bits of functionality.

The main thing I want to point to, is that I believe we should either remove most descriptions from the <Section> component, or perhaps create a separate <Section> component for "Projects" or "Proposals", so we can organize a <Header> that includes things like [Earmark][Round][Category][Date Created].

By having a <DocumentSection> component or something similar, we can perhaps improve the <Header>, and place the [Description], so the content that we add to the page, sits properly in the body. Screenshot from 2022-03-16 21-11-32

Without this adjustment (as visible below), we have a poor layout. I propose we build a separate component which includes a structure similar to the following, and we use this for the ProjectPage, ProposalPage, and ReviewProposal pages: <Header> <Description> <Slot></Slot> <Footer> <Actions>

Screenshot from 2022-03-16 21-15-14 Screenshot from 2022-03-16 21-15-27

idiom-bytes commented 2 years ago

I think this looks good to go.

idiom-bytes commented 2 years ago

I improved various aspects of the user<->admin UX journey. I have now done an end-to-end test, and validated various aspects of how this is working. I have also fixed some bugs, and have gotten it into a more complete state.

Screenshot from 2022-03-21 17-10-27 Screenshot from 2022-03-21 22-45-01

I think we should now set this PR to merge against development so we can have our staging environment updated.