hellbot
commented
1 year ago A dirty solution is to custom process TXT records in octodns_bind:_apply
def _apply(self, plan):
desired = plan.desired
auth_params = self._auth_params()
update = DnsUpdate(desired.name, **auth_params)
for change in plan.changes:
record = change.record
name, ttl, _type, rdatas = record.rrs
# Special handling for TXT records. 255 is a maximum length of one TEXT record chunk
if _type == 'TXT':
for index, value in enumerate(rdatas):
chunks = []
for chunk in [value[i:i + 255] for i in range(0, len(value), 255)]:
chunks.append(f'"{chunk}"')
rdatas[index] = " ".join(chunks)
if isinstance(change, Create):
update.add(name, ttl, _type, *rdatas)
elif isinstance(change, Update):
update.replace(name, ttl, _type, *rdatas)
else: # isinstance(change, Delete):
update.delete(name, _type, *rdatas)
r: dns.message.Message = dns.query.tcp(
update, self.host, port=self.port, timeout=self.timeout
)
if r.rcode() != dns.rcode.NOERROR:
raise Rfc2136ProviderUpdateFailed(dns.rcode.to_text(r.rcode()))
self.log.debug(
'_apply: zone=%s, num_records=%d', name, len(plan.changes)
)
return TrueThis also will deal with octodns/octodns#1088 but I'm unsure it is a proper way to do it
ross
paulgear
If you attempt to update TXT record it won't fail but will split txt line into parts by spaces. And this leads to lost all spaces in txt records.
@ IN TXT "A custom zone!"will became@ IN TXT "Acustomzone!"and octodns will always attempt to update itThis happens due to dnspython rdata tokenizer (which parses a string) it counts spaces by delimiters and to avoid it you have to surround your rdata string with quotes. But there is no way to set quotes for txt record in octodns configuration files (I've tried yaml & zones) - it always strips them.